If we are updating dts of any of the file and it affects global scope, everything needs update in signature and dts emit #48600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
…, everything needs update in signature and dts emit Fixes #42769
sheetalkamat
force-pushed
the
staleErrors
branch
from
768f7ef to
e638aec
Compare
Merged
|
Ping @andrewbranch @amcasey |
|
So a high-level summary would be that, whereas we used to loop over all keys, we now check whether each has global effects and stop iterating once we find and perform a global update? |
|
Yes |
Jack-Works
pushed a commit
to Jack-Works/TypeScript
that referenced
this pull request
Apr 22, 2022
…, everything needs update in signature and dts emit (microsoft#48600) * Add test * Renames * More refactoring * If we are updating dts of any of the file and it affects global scope, everything needs update in signature and dts emit Fixes microsoft#42769
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42769
768f7ef is the actual fix.
Rest is just some renames to make it easier to update and are changes better viewed per commit