Proposal: simplify auto import descriptions #47631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
andrewbranch
requested review from
sandersn,
DanielRosenwasser,
mjbvz and
amcasey
mjbvz
approved these changes
Jan 27, 2022
amcasey
approved these changes
Jan 27, 2022
| @@ -6354,18 +6354,14 @@ | |||
| "category": "Message", | |||
| "code": 90012 | |||
| }, | |||
| "Import '{0}' from module \"{1}\"": { | |||
| "Import '{0}' from \"{1}\"": { | |||
There was a problem hiding this comment.
This is used for both add and update? Also, nitpicky, but why one set of single quotes and one set of double quotes?
There was a problem hiding this comment.
I don't think I even see this message used the diff. Am I missing it?
There was a problem hiding this comment.
I missed it too - it's referred to by its property name in the tests.
There was a problem hiding this comment.
@amcasey yes, both add and update. We always use double quotes for module specifiers for some reason, and single quotes for other code quoting 🤷♂️
| importKind === ImportKind.Default ? Diagnostics.Add_default_import_0_to_existing_import_declaration_from_1 : Diagnostics.Add_0_to_existing_import_declaration_from_1, | ||
| symbolName, | ||
| moduleSpecifierWithoutQuotes | ||
| ]; // you too! |
There was a problem hiding this comment.
I left it in for so long, never knowing what it was referencing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compliments #47552 and makes progress on #47521.
Now, when a codefix will result in a new import declaration, the message is
Add import from "foo". When adding an import to an existing import declaration, the message isUpdate import from "foo".The exception is when the thing being imported doesn’t share a name with the identifier that triggered the error—the only way this happens today is when you are prompted to importReact(or whatever your JSX element factory is) on an arbitrary JSX element name. In that case, the message isImport 'React' from "react".This change is based on two assumptions: