Move function typed properties from the SourceFile to a dedicated functions #1700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // from this SourceFile that are being held onto may change as a result (including | ||
| // becoming detached from any SourceFile). It is recommended that this SourceFile not | ||
| // be used once 'update' is called on it. | ||
| export function update(sourceFile: SourceFile, newText: string, textChangeRange: TextChangeRange): SourceFile { |
|
Looks good, but hard to see exactly what changed in the large blocks that moved. |
|
Large blocks are mostly auxiliary function that were used by |
| @@ -391,7 +391,7 @@ module FourSlash { | |||
| this.currentCaretPosition = pos; | |||
|
|
|||
| var lineStarts = ts.computeLineStarts(this.getCurrentFileContent()); | |||
| var lineCharPos = ts.getLineAndCharacterOfPosition(lineStarts, pos); | |||
| var lineCharPos = ts.computeLineAndCharacterOfPosition(lineStarts, pos); | |||
There was a problem hiding this comment.
What's the difference between this and getLineAndCharacterOfPosition?
There was a problem hiding this comment.
computeLineAndCharacterOfPosition accepts lineMap as number[] and use it to compute line and character. getLineAndCharacterOfPosition accepts SourceFile, picks lineMap from the file (and initializes it if it was not yet created) and then invokes computeLineAndCharacterOfPosition
|
👍 |
vladima
added a commit
that referenced
this pull request
Feb 3, 2015
Move function typed properties from the SourceFile to a dedicated functions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function typed properties on SourceFile are made with closures, for all source files it will keep the parser instance alive. This PR makes SourceFile pure data object -> no closures are required