Skip to content

Performance regression in #33252 #36564

Closed
@amcasey

Description

@amcasey

The extra work done in #33252 is valuable, but maybe it doesn't need to be so expensive.

Setup:

  1. Clone https://github.com/amcasey/material-ui.git
  2. Check out Benchmark
  3. yarn to restore packages
  4. yarn typescript to prebuild and run some TS tests

Repro

  1. tsc -p docs

On a random Mac Mini:

  • 10-run avg on 72bb4c2: 30,872ms
  • 10-run avg on c5e6d95: 33,268ms (8% slower)

Note: to build old TS commits, you probably need to change const { default: chalk } to const chalk in scripts/build/utils.js.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Domain: PerformanceReports of unusually slow behaviorFix AvailableA PR has been opened for this issueNeeds InvestigationThis issue needs a team member to investigate its status.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions