Update core dependencies #1854
Update core dependencies #1854
Conversation
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
| } | ||
|
|
||
| interface MessageEventTarget { | ||
| /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/DedicatedWorkerGlobalScope/message_event) */ |
There was a problem hiding this comment.
The link is suboptimal in this very file. Optimal would be
https://developer.mozilla.org/en-US/docs/Web/API/Window/message_event
There was a problem hiding this comment.
Nothing is optimal actually as MessageEventTarget can be implemented by multiple interfaces. And Window doesn't implement it, that one is coming from WindowEventHandlers. Using worker on window lib is indeed weird though.
| } | ||
|
|
||
| interface MessageEventTarget { | ||
| /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/DedicatedWorkerGlobalScope/message_event) */ |
There was a problem hiding this comment.
Nothing is optimal actually as MessageEventTarget can be implemented by multiple interfaces. And Window doesn't implement it, that one is coming from WindowEventHandlers. Using worker on window lib is indeed weird though.
|
LGTM |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
Automated changes by create-pull-request GitHub action