Skip to content

logging: Add handler param to basicConfig. #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

logging: Add handler param to basicConfig. #1023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions python-stdlib/logging/logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@ def basicConfig(
format=None,
datefmt=None,
level=WARNING,
handler=None,
stream=None,
encoding="UTF-8",
force=False,
Expand All @@ -237,10 +238,14 @@ def basicConfig(
h.close()
logger.handlers = []

if filename is None:
handler = StreamHandler(stream)
else:
handler = FileHandler(filename, filemode, encoding)
if handler is not None:
if filename is None:
handler = StreamHandler(stream)
else:
handler = FileHandler(filename, filemode, encoding)
elif stream or filename:
raise ValueError("'stream' or 'filename' should not be "
"specified together with 'handler'")

handler.setLevel(level)
handler.setFormatter(Formatter(format, datefmt))
Expand Down
Loading