Support Windows ARM64 #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Jun 2, 2021
ghost
commented
- Cherry-pick commits for .NET Core/.NET 5 support from master
- Cherry-pick test fixes from master
- Enable ARM64 libgit2 loading
…ad packed native libraries. LibGit2Sharp includes a number of native libraries that are built on different OSes. These native libraries have a dependency on OpenSSL and the system c-library. On x64, in case the Linux flavor is not known, a fallback is performed to the 'linux-x64' native library. This library is built with a dependency on OpenSSL 1.0. OpenSSL 1.0 is deprecated by OpenSSL 1.1, so on more recent version of Linux, the 'linux-x64' library fails to load. On arm64, native libraries are currently included for debian.* (OpenSSL 1.1) and ubuntu.18.04 (OpenSSL 1.0). Loading on other distros will fail. In both cases LibGit2Sharp is probably including a library that works, but the default resolution logic is not able to find it. By using the 'NativeLibrary' class (.NET Core 3.0) we can extend the resolution logic, and try to load the other native libraries that are packed with LibGit2Sharp.
libgit2 validates objects when signing; update our test to use a valid commit and tree object.
ghost
force-pushed
the
A-Ovchinnikov/win-arm64-take2
branch
from
96fd648 to
f154641
Compare
ghost
marked this pull request as ready for review
ghost
pushed a commit
that referenced
this pull request
Jul 18, 2022
* Cherry-pick some commits from `master` branch * Delete Travis, AppVeyor and Azure Pipelines CI * Enable loading arm64 libgit2 * Use .NET 5.0 for tests Co-authored-by: Tom Deseyn <tom.deseyn@gmail.com> Co-authored-by: Brandon Ording <bording@gmail.com> Co-authored-by: Andrew Arnott <andrewarnott@gmail.com> Co-authored-by: Frederik Carlier <frederik.carlier@quamotion.mobi> Co-authored-by: Edward Thomson <ethomson@edwardthomson.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.