Skip to content

Move import of ImageComparisonTest to exception handler. #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 28, 2018

This will allow Matplotlib to deprecate and ultimately remove
ImageComparisonTest (which is mostly pointless now, as a nose-runner
that uses pytest markers...).

Also allowed myself to add vim swap files to gitignore.

This will allow Matplotlib to deprecate and ultimately remove
ImageComparisonTest (which is mostly pointless now, as a nose-runner
that uses pytest markers...).

Also allowed myself to add vim swap files to gitignore.
Copy link
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me since that is the only line where MplImageComparisonTest is used.

@astrofrog astrofrog merged commit 574299c into matplotlib:master Jun 10, 2018
@anntzer anntzer deleted the moveimport branch June 10, 2018 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants