Skip to content

Fix description and remove unused code from scatter example #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Fix description and remove unused code from scatter example #21

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5413678
Fix description and remove unused code from scatter example
ksunden Nov 23, 2022
7e1d30d
Add a sentence describing the plot
ksunden Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 4 additions & 14 deletions examples/simple_scatter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
"""
==========================
An animated lissajous ball
==========================

Inspired by https://twitter.com/_brohrer_/status/1584681864648065027

==================================================
An simple scatter plot using PathCollectionWrapper
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A, and do cross-references work here? (Also if it's still a lassajous, why not say that?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not lissajous, I just was having a transform problem originally, so I copied that example and simplified it in a couple steps and then decided it was worth keeping as an example that didn't have animations, etc. Just didn't change the title/description.

I will try to properly cross reference

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that is standard practice to not use cross references in titles, so I will add a sentence underneath with the cross references

==================================================

A quick example using ``containers.ArrayContainer`` and ``wrappers.PathCollectionWrapper``.
"""
import numpy as np

Expand All @@ -16,11 +14,6 @@

from data_prototype.wrappers import PathCollectionWrapper


def update(frame, art):
return art


marker_obj = mmarkers.MarkerStyle("o")

cont = ArrayContainer(
Expand All @@ -37,7 +30,4 @@ def update(frame, art):
ax.set_ylim(0, 5)
lw = PathCollectionWrapper(cont, offset_transform=ax.transData)
ax.add_artist(lw)
# ax.set_xticks([])
# ax.set_yticks([])
# ax.set_aspect(1)
plt.show()