Use clearer names in query signature #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a conversation with someone at pydata the name "transform" was confused from "axes to data coordinate transform" to "data-aggregation-pipeline". This is fairly a "transform" but is not the transform that is meant.
ksunden
reviewed
Nov 15, 2022
This way implementers can pick a shorter name than "coord_transform".
tacaswell
force-pushed
the
api_better_names
branch
from
ab95f80 to
f17882e
Compare
ksunden
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a conversation with someone at pydata the name "transform" was confused from "axes to data
coordinate transform" to "data-aggregation-pipeline". This is fairly a "transform" but is not the transform that is meant.