Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
here is my attempt to make pyshp optional. It introduces an environment variable PYSHP_dir that can be set to use an external copy of pyshp. If it is undefined the bundled version is used.
I could not find a "standard" method to do this in setup tools, so the changes in setup.py look somewhat like a workaround. It copies opt_lib/mpl_toolkits/basemap/shapefile.py to lib/mpl_toolkits/basemap/shapefile.py if the bundled version is to be used, then runs the setup function, and removes the file again after running this function.
Anyway, it seems to work correctly on my system, so if you think this is acceptable, you're welcome to merge in this pull request.