Actionable error message for large json documents #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using
assertJsonDocumentMatches
, it is hard to navigate the error message when the assertion fails.The message only states that the given JSON document is not a match of the provided constraints.
It would be great to also tell which constraint(s) the JSON document fails to satisfy.
Solution
I implement
additionalFailureDescription
inJsonValueMatchesMany
constraint to return a string representation of constraints that fail during evaluations.The result would look like this.
I think this would greatly simplify investigation when the tests fail.
Thank you