fix: some windows versions don't make this directory? #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In general, I don’t like to supress errors if I don’t understand why they happen. But is there any way to find out? |
|
I guess the way to find out is to get a Windows 3.7 or 3.8 installation and try those commands. I'm not a fan of suppressing errors either, but in this case, we're trying to delete a directory. Is it really an error that the directory doesn't exist in the first place? |
nedbat
force-pushed
the
source_in_third_paths
branch
from
59c3143 to
0eb5170
Compare
|
Another option is to check if the directory exists before trying to remove it. |
|
I don’t think that checking that the directory exists has much advantage over suppressing the error. The existence or non-existence of the directories is not at all relevant to the test. The reason why I added the code to delete the directories is to make it not blow up up in the cleanup part of |
We were seeing these failures in the nightly builds:
```
FAILED tests/test_arcs.py::LoopArcTest::test_continue - AssertionError:
Possible arcs differ: minus is expected, plus is actual
(-1, 1) # .1
(1, 2) # 12
(1, 5) # 15
(2, 3) # 23
(3, 1) # 31
- (4, 1) # 41
(5, -1) # 5.
Missing arcs differ: minus is expected, plus is actual
- (4, 1) # 41
+
assert False
FAILED tests/test_arcs.py::LoopArcTest::test_break - AssertionError:
Possible arcs differ: minus is expected, plus is actual
(-1, 1) # .1
(1, 2) # 12
(1, 5) # 15
(2, 3) # 23
(3, 5) # 35
- (4, 1) # 41
(5, -1) # 5.
Missing arcs differ: minus is expected, plus is actual
(1, 5) # 15
- (4, 1) # 41
assert False
FAILED tests/test_arcs.py::ExceptionArcTest::test_raise_followed_by_statement - AssertionError:
Possible arcs differ: minus is expected, plus is actual
(-1, 1) # .1
(1, 2) # 12
(2, 3) # 23
(3, 4) # 34
(4, 6) # 46
- (5, 8) # 58
(6, 7) # 67
(7, 8) # 78
(8, -1) # 8.
Missing arcs differ: minus is expected, plus is actual
- (5, 8) # 58
+
assert False
FAILED tests/test_coverage.py::SimpleStatementTest::test_raise_followed_by_statement - AssertionError: [1, 2, 4, 5] != [1, 2, 3, 4, 5]
assert [1, 2, 4, 5] == [1, 2, 3, 4, 5]
At index 2 diff: 4 != 3
Right contains one more item: 5
Full diff:
- [1, 2, 3, 4, 5]
? ---
+ [1, 2, 4, 5]
FAILED tests/test_coverage.py::SimpleStatementTest::test_break - AssertionError: [1, 2, 3, 5] != [1, 2, 3, 4, 5]
assert [1, 2, 3, 5] == [1, 2, 3, 4, 5]
At index 3 diff: 5 != 4
Right contains one more item: 5
Full diff:
- [1, 2, 3, 4, 5]
? ---
+ [1, 2, 3, 5]
FAILED tests/test_coverage.py::SimpleStatementTest::test_continue - AssertionError: [1, 2, 3, 5] != [1, 2, 3, 4, 5]
assert [1, 2, 3, 5] == [1, 2, 3, 4, 5]
At index 3 diff: 5 != 4
Right contains one more item: 5
Full diff:
- [1, 2, 3, 4, 5]
? ---
+ [1, 2, 3, 5]
```
We build the .pip files on Mac. Some transitive dependencies are
different on other OS's, and so would fail there, like this:
```
ERROR: In --require-hashes mode, all requirements must have their versions pinned with ==. These do not:
SecretStorage>=3.2 from https://files.pythonhosted.org/packages/54/24/b4293291fa1dd830f353d2cb163295742fa87f179fcc8a20a306a81978b7/SecretStorage-3.3.3-py3-none-any.whl#sha256=f356e6628222568e3af06f2eba8df495efa13b3b63081dafd4f7d9a7b7bc9f99 (from keyring==23.13.1->-r requirements/dev.pip (line 279))
```
By keeping the .in files self-contained, we provide a way to install
without hashes.
With .ref, on a PR from a fork, I got:
```
Run actions/dependency-review-action@v3
with:
base-ref: master
head-ref: xml_duplicate_fix
repo-token: ***
fail-on-severity: low
fail-on-scopes: runtime
Error: Bad Request
```
* fix: generate xml report packages correctly on windows * test: check duplicate package names in xml report * fix: shorten long line in test_xml
…ty location There is logic to not measure third-party packages inside configured sources. However, when a (i.e. another) configured source was inside a third-party location, this logic was previously disabled completely. This caused a problem if a virtual env is set up inside a configured source directory and a configured source package gets installed inside the virtual env. Previously in this case, coverage was measured for all files in the virtual env for the reason described in the previous paragraph. This commit changes the code to collect all configured source directories inside third-party locations and disable coverage for code in third-party locations only if its not in one of these collected source directories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the failing Windows tests, but I'm not sure if it's the right way. I don't know why those directories are missing on Windows 3.7 and 3.8.