Fix IE11 error in Shopping Cart #8108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bringing repo up to date
This browser may only account for <10% of all traffic on many sites, but that's still a statistically significant quantity.
vasiliyseleznev
requested review from
omiroshnichenko
and removed request for
que-etc
|
Hi, @Sanfam. |
|
@Sanfam thanks for the contribution! I'm closing it now, but if you still can reproduce the issue please open another PR. |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Feb 6, 2023
PR-L3-2023-01-31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checkout attempts to call a resize event that IE11 cannot use. This breaks shipping rate calculation on this page. While it doesn't prevent a user from moving forward, the effect is misleading and implies that they have stalled.
If they're using IE11 in 2017, odds are good that this is enough to deter them from proceeding any further.