Skip to content

Fix the issue #39944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from
Open

Fix the issue #39944

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dev/tests/integration/framework/Magento/TestFramework/Store/StoreManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*/
namespace Magento\TestFramework\Store;

use Magento\Framework\Interception\InterceptorInterface;
use Magento\Framework\App\Config\ScopeConfigInterface;
use Magento\TestFramework\App\Config;
use Magento\TestFramework\ObjectManager;

Expand Down Expand Up @@ -127,7 +127,7 @@ public function reinitStores()
//In order to restore configFixture values
$testAppConfig = ObjectManager::getInstance()->get(Config::class);
$reflection = new \ReflectionClass($testAppConfig);
if ($reflection->implementsInterface(InterceptorInterface::class)) {
if ($reflection->implementsInterface(ScopeConfigInterface::class)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this check for ScopeConfigInterface OR InterceptorInterface? We need to make sure this works for the case, where there is a plugin defined, but also if there is no plugin.

$reflection = $reflection->getParentClass();
}
$dataProperty = $reflection->getProperty('data');
Expand Down