Update frontend_label and apply_to in CategoryAttribute Fixture.

[JamelleG]

Description (*)

This PR aims to address issues discovered when trying to use the following fixture. app/code/Magento/Catalog/Test/Fixture/CategoryAttribute.php

1. Using it without setting any values results in the following errror

Unable to apply fixture: Magento\Catalog\Test\Fixture\CategoryAttribute (attr)
Caused by
PHPUnit\Framework\Exception: Warning: Array to string conversion in /var/www/html/lib/internal/Magento/Framework/DB/Adapter/Pdo/Mysql.php:3337.

2. Label does not get set as it's setting it to default_frontend_label when the value that it actually saves/loads from is frontend_label.

Changes

1. Update apply_to to have a default of category which I took from dev/tests/api-functional/testsuite/Magento/GraphQl/CatalogGraphQl/AttributesMetadataTest.php
2. Update default_frontend_label to frontend_label

Manual testing scenarios (*)

1. Create an integration test with using the fixture app/code/Magento/Catalog/Test/Fixture/CategoryAttribute.php
2. Confirm that you can create category attribute overriding any of the data such as apply_to and no errors should occur.
3. Confirm that the test succeeds as label should not be null as it's set in the default data for given fixture.

<?php

namespace integration\testsuite\Magento\Catalog;

use Magento\Catalog\Test\Fixture\CategoryAttribute;
use Magento\TestFramework\Fixture\DataFixture;
use Magento\TestFramework\Fixture\DataFixtureStorageManager;
use PHPUnit\Framework\TestCase;

class CategoryLabelFixtureTest extends TestCase
{

    #[
        DataFixture(CategoryAttribute::class, [], as: "attr")
    ]
    public function testCategoryLabelFixture(): void
    {
        $fixture = DataFixtureStorageManager::getStorage();
        $categoryAttribute = $fixture->get('attr');
        $this->assertNotNull($categoryAttribute->getDefaultFrontendLabel());
    }
}

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Update frontend_label and apply_to in CategoryAttribute Fixture. #39942: Update frontend_label and apply_to in CategoryAttribute Fixture.

[m2-assistant]

Hi @JamelleG. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Hotel]

@magento create issue