Fix swatch-renderer.js

[fisch42]

Fix for "Uncaught TypeError: salableProducts is undefined" when no variant is available

Description (*)

This code fixes an error, when a configurable product has no available variant.

This is the JS error in the browser console:

Uncaught TypeError: salableProducts is undefined        swatch-renderer.js:514:29
    disableSwatchForOutOfStockProducts Magento_Swatches/js/swatch-renderer.js:514
    jQuery 2
    disableSwatchForOutOfStockProducts Magento_Swatches/js/swatch-renderer.js:511
    each jQuery
    disableSwatchForOutOfStockProducts Magento_Swatches/js/swatch-renderer.js:504

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Fix swatch-renderer.js #39925: Fix swatch-renderer.js

[m2-assistant]

Hi @fisch42. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Bravo]

@magento create issue

[Copilot]

Pull Request Overview

This pull request adds a guard to prevent salableProducts from being accessed when it’s undefined, avoiding the TypeError in swatch-renderer.js.

• Added a check for salableProducts before using hasOwnProperty
• Included a length check to skip disabling when no variants are available

[Copilot]

The added salableProducts.length > 0 check assumes salableProducts is an array and will skip disabling options when it's an object (empty or not). Instead, guard only against undefined and then check properties, e.g.: if (salableProducts && !salableProducts.hasOwnProperty(optionId)) { … }.

Suggested change

	if (salableProducts != undefined && salableProducts.length > 0 && !salableProducts.hasOwnProperty(optionId)) {
	if (salableProducts && !salableProducts.hasOwnProperty(optionId)) {