Get existing page data only on edit page #39746

Mohamed-Asar · 2025-03-18T09:24:37Z

Description (*)

Get Page data only on the edit page

Fixed Issues (if relevant)

Fixes "The CMS page with the "0" ID doesn't exist" log flood #39743

Manual testing scenarios (*)

Log into admin
Navigate to Content->Pages->Add New Page
Verify System.log don't have any error log related to cms page

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

m2-assistant · 2025-03-18T09:24:40Z

Hi @Mohamed-Asar. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

Mohamed-Asar · 2025-03-18T09:24:52Z

@magento run all tests

engcom-Hotel · 2025-04-23T05:21:03Z

@magento run all tests

engcom-Hotel

Hello @Mohamed-Asar,

Thanks for the contribution!

The changes seems good to us, but please fixed the failed static test.

Thanks

Mohamed-Asar · 2025-04-24T13:24:33Z

@engcom-Hotel Static test failure is not related to this PR changes ? do you want me to fix that ?

engcom-Hotel · 2025-04-25T05:58:03Z

Hello @Mohamed-Asar,

To proceed further with the PR, we need a green build, and for this you need to fix the static test failure. Please let us know if you have any query regarding that.

Thanks

Mohamed-Asar · 2025-04-25T06:23:43Z

Sure @engcom-Hotel, Looks like we need to refactor the class, i will fix and let you know

…into issue/39743-cms-page-error-log-fix

engcom-Hotel · 2025-05-21T13:24:37Z

Hello @Mohamed-Asar,

Have you got a chance to look into this?

Thanks

Mohamed-Asar · 2025-05-22T06:18:41Z

@engcom-Hotel i have started working on it, will let you know once done

Mohamed-Asar · 2025-05-23T10:15:38Z

@magento run all tests

Mohamed-Asar · 2025-05-23T15:15:40Z

@magento run all tests

Mohamed-Asar · 2025-05-26T06:10:01Z

@engcom-Hotel Fixed the static test, please review

engcom-Hotel · 2025-05-27T05:45:32Z

@magento run all tests

engcom-Hotel

Hello @Mohamed-Asar,

Thanks for the updates!

The changes looks good to us, but some minor changes required as below. Please look into the review comments.

Thanks

engcom-Hotel · 2025-05-27T09:59:49Z

app/code/Magento/Cms/Model/Page/Service/PageService.php

+        private PageRepositoryInterface $pageRepository,
+        private PageFactory $pageFactory,
+        private CustomLayoutManagerInterface $customLayoutManager,


I guess all properties can be readonly.

@engcom-Hotel added readonly

engcom-Hotel · 2025-05-27T10:16:20Z

app/code/Magento/Cms/Model/Page/Service/PageService.php

+/**
+ * Cms Page Service Class
+ */
+class PageService


PageService can be unit tested for the logic of getPageById, createPageFactory, and fetchAvailableCustomLayouts.

Integration tests could ensure data provider works as expected in edit page scenarios.

@engcom-Hotel i have added unit test case, please review

Mohamed-Asar · 2025-06-02T14:22:05Z

@magento run all tests

engcom-Bravo · 2025-06-04T08:17:18Z

Hi @Mohamed-Asar,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

Install fresh Magento 2.4-develop

Steps to reproduce

Create admin user
Open BO->Content->Pages->Add New Page

Before: ✖️

[2025-06-04T08:08:07.146477+00:00] main.ERROR: The CMS page with the "0" ID doesn't exist. [] []

After: ✔️

system.log is empty

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

engcom-Dash · 2025-06-05T04:56:54Z

@magento run all tests

engcom-Dash · 2025-06-05T08:00:41Z

@magento run Functional Tests B2B, Functional Tests EE, Functional Tests CE

engcom-Dash · 2025-06-05T13:11:50Z

The consistent test failures for Functional B2B are known Issues and JIRA is raised for them. Other failures are inconsistent and seems to be flaky. They neither part of PR nor failing because of the PR changes.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39746/c729012052df652ddd16635f7c144124/Functional/allure-report-b2b/#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39746/9ddbda0a9fb980a7873dd3d9dd7b8da1/Functional/allure-report-b2b/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Known Issues:
OrderWithMultipleConfigurableProductsAdditionalStockTest : ACQE-8060
EnablePaypalExpressCheckoutAndSubmitAnOrderUsingPaypalExpressCheckoutTest : ACQE-8007
StoreFrontSimpleProductWithSpecialAndTierDiscountPriceTest : ACQE-7971

The consistent test failure for Functional CE is known Issues and JIRA is raised for the same. Other failure is inconsistent and seems to be flaky. They neither part of PR nor failing because of the PR changes.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39746/c46daae5185acd6879e62aac8e5c3f41/Functional/allure-report-ce/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39746/6f7d3938e098b01076be33249c61adb1/Functional/allure-report-ce/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Known Issues:
EnablePaypalExpressCheckoutAndSubmitAnOrderUsingPaypalExpressCheckoutTest : ACQE-8007

The consistent test failure for Functional EE is known Issues and JIRA is raised for the same. Other failure is inconsistent and seems to be flaky. They neither part of PR nor failing because of the PR changes.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39746/318ccf3f139d5fb4e920ae0077bb8afd/Functional/allure-report-ee/index.html#categories/47999e1f828641ba54c4c4f35f7decea/4c7cdd5f84fcb655/

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39746/a7080822ec085e377783bb9ce7b18945/Functional/allure-report-ee/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Known Issues:
EnablePaypalExpressCheckoutAndSubmitAnOrderUsingPaypalExpressCheckoutTest : ACQE-8007

Hence moving this PR in Merge In Progress.

Get existing page data only on edit page

8a2af09

m2-github-services added Partner: Ziffity partners-contribution Pull Request is created by Magento Partner labels Mar 18, 2025

engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 18, 2025

engcom-Charlie added the Project: Community Picked PRs upvoted by the community label Apr 10, 2025

engcom-Charlie added this to Community Dashboard Apr 10, 2025

engcom-Charlie moved this to Pending Review in Community Dashboard Apr 10, 2025

Merge branch '2.4-develop' into issue/39743-cms-page-error-log-fix

f1fb5e2

engcom-Hotel requested changes Apr 23, 2025

View reviewed changes

engcom-Hotel moved this from Pending Review to Changes Requested in Community Dashboard Apr 25, 2025

ct-prd-projects-boards-automation bot added the Progress: needs update label Apr 25, 2025

Merge branch '2.4-develop' of https://github.com/Mohamed-Asar/magento2 …

bd6c526

…into issue/39743-cms-page-error-log-fix

Static test fix - reduce coupling in page data provider with service

f8474ec

Strict types added

2c1b4db

Mohamed-Asar requested a review from engcom-Hotel May 26, 2025 06:09

ct-prd-projects-boards-automation bot added Progress: review and removed Progress: needs update labels May 26, 2025

ct-prd-projects-boards-automation bot moved this from Changes Requested to Review in Progress in Community Dashboard May 26, 2025

Merge branch '2.4-develop' into issue/39743-cms-page-error-log-fix

5aba121

engcom-Hotel requested changes May 27, 2025

View reviewed changes

engcom-Hotel moved this from Review in Progress to Changes Requested in Community Dashboard May 27, 2025

ct-prd-projects-boards-automation bot added Progress: needs update and removed Progress: review labels May 27, 2025

Unit test added for page service class and code review changes

b3b389e

Mohamed-Asar requested a review from engcom-Hotel June 2, 2025 14:21

ct-prd-projects-boards-automation bot added the Progress: review label Jun 2, 2025

ct-prd-projects-boards-automation bot removed the Progress: needs update label Jun 2, 2025

ct-prd-projects-boards-automation bot moved this from Changes Requested to Review in Progress in Community Dashboard Jun 2, 2025

engcom-Hotel approved these changes Jun 3, 2025

View reviewed changes

ct-prd-projects-boards-automation bot removed the Progress: review label Jun 3, 2025

ct-prd-projects-boards-automation bot moved this from Review in Progress to Ready for Testing in Community Dashboard Jun 3, 2025

ct-prd-projects-boards-automation bot added the Progress: ready for testing label Jun 3, 2025

engcom-Bravo self-assigned this Jun 4, 2025

engcom-Bravo moved this from Ready for Testing to Testing in Progress in Community Dashboard Jun 4, 2025

engcom-Bravo moved this from Testing in Progress to Extended testing (optional) in Community Dashboard Jun 4, 2025

engcom-Dash self-assigned this Jun 4, 2025

Merge branch '2.4-develop' into issue/39743-cms-page-error-log-fix

aaf1c99

engcom-Dash moved this from Extended testing (optional) to Merge in Progress in Community Dashboard Jun 5, 2025

engcom-Dash removed the Progress: ready for testing label Jun 5, 2025

Get existing page data only on edit page #39746

Are you sure you want to change the base?

Get existing page data only on edit page #39746

Conversation

Mohamed-Asar commented Mar 18, 2025

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Mar 18, 2025

Uh oh!

Mohamed-Asar commented Mar 18, 2025

Uh oh!

engcom-Hotel commented Apr 23, 2025

Uh oh!

engcom-Hotel left a comment

Choose a reason for hiding this comment

Uh oh!

Mohamed-Asar commented Apr 24, 2025

Uh oh!

engcom-Hotel commented Apr 25, 2025

Uh oh!

Mohamed-Asar commented Apr 25, 2025

Uh oh!

engcom-Hotel commented May 21, 2025

Uh oh!

Mohamed-Asar commented May 22, 2025

Uh oh!

Mohamed-Asar commented May 23, 2025

Uh oh!

Mohamed-Asar commented May 23, 2025

Uh oh!

Mohamed-Asar commented May 26, 2025

Uh oh!

engcom-Hotel commented May 27, 2025

Uh oh!

engcom-Hotel left a comment

Choose a reason for hiding this comment

Uh oh!

engcom-Hotel May 27, 2025

Choose a reason for hiding this comment

Uh oh!

Mohamed-Asar Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

engcom-Hotel May 27, 2025

Choose a reason for hiding this comment

Uh oh!

Mohamed-Asar Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

Mohamed-Asar commented Jun 2, 2025

Uh oh!

engcom-Bravo commented Jun 4, 2025

✔️ QA Passed

Uh oh!

engcom-Dash commented Jun 5, 2025

Uh oh!

engcom-Dash commented Jun 5, 2025

Uh oh!

engcom-Dash commented Jun 5, 2025

Uh oh!

Uh oh!