-
Notifications
You must be signed in to change notification settings - Fork 9.4k
magento/magento2#39640: Issue with the Customizable Options grid on the product page in the admin panel #39694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
Conversation
…e roles/types set (base/small/thumbnail) and after re-adding "old" roles/types appear - fixed issue with "old" roles/types after re-adding images
…e roles/types set (base/small/thumbnail) and after re-adding "old" roles/types appear - changed copyright
…e roles/types set (base/small/thumbnail) and after re-adding "old" roles/types appear - rolled back a file that was changed by mistake for another issue
Hi @pavel77718. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
1 similar comment
@magento run all tests |
…t page in the admin panel - fixed "var" declaration in method
@magento run all tests |
@magento run all tests |
@magento run Functional Tests B2B, Functional Tests EE, Integration Tests |
@magento run Integration Tests |
@magento run all tests |
@magento run all tests |
@magento run Database Compare, Functional Tests B2B, Functional EE, WebAPI Tests |
@magento run Functional Tests EE |
@magento run all tests |
@magento run Functional Tests B2B, Functional Tests EE |
@magento run all tests |
@magento run Functional Tests B2B, Functional Tests EE |
Hello @pavel77718, According to this review comment #39694 (review), can you please add an automated test for this fix? Thanks |
Hello @pavel77718 I wanted to check if you are working on the automated test coverage. If not, Can I take care of them? Just let me know what works best for you. |
I haven't started working on the tests. You can take care of that. |
@magento run all tests |
@magento run Static Tests, Unit Tests, Functional Tests B2B, Functional Tests EE |
@magento run all tests |
Hello @engcom-Hotel, I have added the jasmine tests for the fix. Also , I feel that the failing test cases are not related to the PR changes. Could you please review it ? Moving this PR to pending review. Thanks! |
Hi @pavel77718, Thanks for the collaboration & contribution! ✔️ QA PassedPreconditions:
Steps to reproduce
Before: ✖️ Screen.Recording.2025-05-15.at.11.36.13.am.movAfter: ✔️ Screen.Recording.2025-05-15.at.2.32.14.pm.movBuilds are failed. Hence, moving this PR to Extended Testing. Thanks. |
@magento run all tests |
@magento run Functional Tests B2B, Static Tests |
The consistent failure in Functional B2B is not related to the PR changes and it is a known issue. The other failure is inconsistent. They neither part of the PR nor failing because of the PR changes. Known issue: StoreFrontSimpleProductWithSpecialAndTierDiscountPriceTest https://jira.corp.adobe.com/browse/ACQE-7971 Static Test FailureThe consistent static test failures are not because of this code changes done in this PR. In order to get the green build, We have raised an approval JIRA for static failures: https://jira.corp.adobe.com/browse/AC-14710 Once we get all the approvals we will move ahead with this PR. For now moving this PR to "Pending Approval" |
Description (*)
As the author of the issue wrote, the problem is that when adding a new option in excess of the configured amount, the interface switches to the second page, but the new value is not added—the page remains in a constant loading state.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Expected result
The interface switches to the third page with the new value.
Contribution checklist (*)