Skip to content

Fixed Magento reorder order id issue #39399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: 2.4-develop
Choose a base branch
from
Open

Fixed Magento reorder order id issue #39399

wants to merge 15 commits into from

Conversation

magentoabu
Copy link
Contributor

@magentoabu magentoabu commented Nov 25, 2024 •
edited
Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes v2.4.7-p1 Magento reorder -1 order numbers #39089

Manual testing scenarios (*)

  1. Open any order, click reorder
  2. Submit the order.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Nov 25, 2024

Hi @magentoabu. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review labels Nov 25, 2024
@magentoabu
Copy link
Contributor Author

@magento run all tests

@magentoabu
Copy link
Contributor Author

@magento run Static Tests, Integration Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B

@Priyakshic Priyakshic added the Project: Community Picked PRs upvoted by the community label Jan 15, 2025
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel engcom-Hotel self-requested a review January 17, 2025 11:38
engcom-Hotel
engcom-Hotel requested changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @magentoabu,

Thanks for the contribution!

Please sign the CLA as it is required to process the PR further. Till the time we are moving this PR On Hold.

Thanks

@magentoabu
Copy link
Contributor Author

Hello @magentoabu,

Thanks for the contribution!

Please sign the CLA as it is required to process the PR further. Till the time we are moving this PR On Hold.

Thanks

CLA signed, please proceed further

@magentoabu
Copy link
Contributor Author

@magento run Static Tests

@engcom-Hotel
Copy link
Contributor

Hello @magentoabu,

It is still showing as unsigned. Please have a look at the cross mark in front of the Adobe CLA Signed? test.

Thanks

@magentoabu
Copy link
Contributor Author

@magento run all tests

engcom-Hotel
engcom-Hotel requested changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @magentoabu,

Thanks for the contribution!

Please add an automated test in accordance to the DOD.

And also look into the below review comment.

Thanks

app/code/Magento/Sales/Model/AdminOrder/Create.php Outdated
@@ -1,6 +1,6 @@
<?php
/**
* Copyright 2011 Adobe
* Copyright 2015 Adobe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be 2011 only as the file has been created in 2011 only

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel
Copy link
Contributor

Hello @magentoabu,

As mentioned here, please also add automated test.

Thanks

@engcom-Hotel engcom-Hotel moved this from Pending Review to Review in Progress in Community Dashboard Mar 18, 2025
engcom-Hotel
engcom-Hotel requested changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @magentoabu,

Thanks for making the changes. I guess the integration test is failing due to the PR Changes. Please look into this.

Thanks

@engcom-Hotel engcom-Hotel moved this from Review in Progress to Changes Requested in Community Dashboard Mar 18, 2025
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run all tests

Den4ik
Den4ik approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@Den4ik Den4ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved
Changes looks good for me.
All logical changes made in #37298 reverted.

Failed Functional Tests are not related to changes in R

@engcom-Charlie
Copy link
Contributor

Fixed the integration test failure.

@engcom-Charlie engcom-Charlie moved this from Changes Requested to Pending Review in Community Dashboard Mar 25, 2025
@engcom-Hotel engcom-Hotel moved this from Pending Review to Ready for Testing in Community Dashboard Mar 25, 2025
@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Testing in Progress in Community Dashboard Mar 26, 2025
@engcom-Bravo
Copy link
Contributor

@magento run all tests

@engcom-Bravo
Copy link
Contributor

Hi @magentoabu,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Steps to reproduce

  • Open any order, click reorder
  • Submit the order.

Before: ✖️ 

Screenshot 2025-03-26 at 1 50 51 pm

After: ✔️

order number with unique 8 digits.

Screenshot 2025-03-26 at 2 01 40 pm

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

@engcom-Bravo engcom-Bravo moved this from Testing in Progress to Extended testing (optional) in Community Dashboard Mar 26, 2025
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE, Integration Tests

@engcom-Charlie
Copy link
Contributor

The consistent test failure of Functional B2B is a known issue. Hence moving this PR to Merge in Progress.

Build 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39399/889b809ab8d69e88f7938b9020e26bdb/Functional/allure-report-b2b/index.html#categories/2fc037f47773dd7551f2e766bbf34efa/ff428befbea0a9b0/
image

Build 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39399/5735671a4ab8fbf0b570fd1e2059b9a8/Functional/allure-report-b2b/index.html#categories/2fc037f47773dd7551f2e766bbf34efa/fa4e07a5eed0251d/

image

Known Issue:
ACQE-7751 : CatalogPriceRuleAndCustomerGroupMembershipArePersistedUnderLongTermCookieTest

@engcom-Charlie engcom-Charlie moved this from Extended testing (optional) to Merge in Progress in Community Dashboard Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Den4ik Den4ik Den4ik approved these changes

@engcom-Hotel engcom-Hotel engcom-Hotel approved these changes

Assignees

@engcom-Charlie engcom-Charlie

Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for testing Project: Community Picked PRs upvoted by the community
Projects
Community Dashboard
Status: Merge in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v2.4.7-p1 Magento reorder -1 order numbers
6 participants
@magentoabu @engcom-Hotel @engcom-Charlie @engcom-Bravo @Den4ik @Priyakshic