-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[BUG] Resolves https://github.com/magento/magento2/issues/39002 #39038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
Conversation
Hi @xavitriu. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Please note that there is already a pull for this |
foreach ($value->getStreet() as $street) { | ||
$messages = $this->isValidPattern($pattern_street, $street, $messages, 'invalid_street', 'Street is not valid!'); | ||
} | ||
$pattern_city = '/(?:[\p{L}\p{M}\s\-\']{1,100})/u'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
city
field in the database accepts 255 signs, i not see why here they will be limited to random "100" symbols.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same must be applied to region
field also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hola a todos:
I'm not xavi but i participate in the coding, we copied all patterns from #38345, you need to point the same there was accepted and is the originator of the bug you saw here, thanks for your help
Resolves #39002