Issue 36096: Layered Navigation does not filter products properly #36102

rogerdz · 2022-09-07T08:54:59Z

Description (*)

Layered Navigation does not filter products properly

Related Pull Requests

Fixed Issues (if relevant)

Fixes Layered Navigation does not filter products properly #36096

Manual testing scenarios (*)

Display product out of stock is set to Yes from STORES > Configuration > Catalog > Inventory > Display Out of Stock Products settings.
Make sure elasticsearch is working correctly
Navigate to Product listing page
Apply any of the filter from filters list

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

m2-assistant · 2022-09-07T08:55:02Z

Hi @rogerdz. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

rogerdz · 2022-09-07T08:55:27Z

@magento run all tests

magento-automated-testing · 2022-09-07T08:55:37Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

edenduong

Hi @rogerdz ,
Thank you for your contribution. Please check my comment.
And as the Magento Definition of Done, this change should be convered by Automation test. I think the Unit/Integration test can be covered that. Could you please add it to this PR ?

edenduong · 2022-09-08T00:13:11Z

app/code/Magento/AdvancedSearch/Model/ResourceModel/Index.php

+     * @return array
+     * @since 100.1.0
+     */
+    protected function _getCatalogProductInventoryData($productIds = null)


Should be private function
_getCatalogProductInventoryData change to getCatalogProductInventoryData as Magento standard code.

edenduong · 2022-09-08T00:18:51Z

app/code/Magento/Elasticsearch/SearchAdapter/Query/Builder/Sort.php

     * @param array $skippedFields
     * @param array $map
     */
    public function __construct(
        AttributeProvider $attributeAdapterProvider,
        FieldNameResolver $fieldNameResolver,
+        ScopeConfigInterface $scopeConfig,


ScopeConfigInterface $scopeConfig should be moved to the end of the contruct because of Backward compatible.

ScopeConfigInterface $scopeConfig = null

and:

$this->scopeConfig = $scopeConfig ?: ObjectManager::getInstance()->get(ScopeConfigInterface::class);

edenduong · 2022-09-08T00:20:55Z

app/code/Magento/Elasticsearch/SearchAdapter/Query/Builder/Sort.php

+     *
+     * @return array
+     */
+    public function getSortBySaleability()


introduce the public function. @sidolov Can you give us some advice about that ?

edenduong · 2022-09-08T00:21:26Z

app/code/Magento/Elasticsearch/SearchAdapter/Query/Builder/Sort.php

+            $fieldName = $this->fieldNameResolver->getFieldName($attribute);
+            $sorts[] = [
+                $fieldName => [
+                    'order' => 'desc'


desc should be changed to constant in the Magento framework

edenduong · 2022-09-08T00:22:55Z

app/code/Magento/Elasticsearch/SearchAdapter/Query/Builder/Sort.php

+        $sorts = [];
+
+        if ($this->hasShowOutOfStockStatus()) {
+            $attribute = $this->attributeAdapterProvider->getByAttributeCode('is_salable');


Should declare the constant for the is_salable

edenduong · 2022-09-08T00:24:11Z

app/code/Magento/AdvancedSearch/Model/ResourceModel/Index.php

+     * @param int $websiteId
+     * @return array
+     */
+    public function getInventoryIndexData($productIds, $websiteId = null)


introduce the public function make the Semantic test failed. @sidolov Can you give us some advice about that ?

Backward capability don't allow introduce new public methods to class marked as @api and should be replaced by new class

khnaim · 2022-10-03T10:31:19Z

Hello,

I have de same problem (Adobe Commerce ver. 2.4.5).

I applied the patch proposed by @edenduong , but the problem still persists

Do you have a solution to fix this problem?

TIA
m245_issues_36102.txt

Issue 36096: Layered Navigation does not filter products properly

eb4f3b6

m2-community-project bot added the Progress: pending review label Sep 7, 2022

edenduong requested changes Sep 8, 2022

View reviewed changes

m2-community-project bot assigned edenduong Sep 8, 2022

m2-community-project bot added Progress: needs update and removed Progress: pending review labels Sep 8, 2022

edenduong added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Component: Elasticsearch labels Sep 8, 2022

rogerdz mentioned this pull request Sep 8, 2022

Custom sorting on category pages not working if out of stock products are shown #36113

Closed

5 tasks

sdzhepa added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Sep 8, 2022

rogerdz and others added 3 commits September 11, 2022 23:37

Merge branch '2.4-develop' into fix-issue-36096

a0b4d26

issue 36096: update code

4863da3

issue 36096: update code

3859540

m2-community-project bot assigned Den4ik Sep 13, 2022

m2-community-project bot added Progress: review and removed Progress: needs update labels Sep 13, 2022

rogerdz mentioned this pull request Oct 4, 2022

Unable to sort catalog by Custom Attribute of type Dropdown #35920

Closed

5 tasks

m2-community-project bot added Progress: pending review and removed Progress: review labels Dec 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Issue 36096: Layered Navigation does not filter products properly #36102

Issue 36096: Layered Navigation does not filter products properly #36102

Uh oh!

rogerdz commented Sep 7, 2022

Uh oh!

m2-assistant bot commented Sep 7, 2022

Uh oh!

rogerdz commented Sep 7, 2022

Uh oh!

magento-automated-testing bot commented Sep 7, 2022

Uh oh!

edenduong left a comment

Uh oh!

edenduong Sep 8, 2022

Uh oh!

edenduong Sep 8, 2022

Uh oh!

edenduong Sep 8, 2022

Uh oh!

edenduong Sep 8, 2022

Uh oh!

edenduong Sep 8, 2022

Uh oh!

edenduong Sep 8, 2022

Uh oh!

Den4ik Sep 13, 2022

Uh oh!

khnaim commented Oct 3, 2022 •

edited

Loading

Uh oh!

Uh oh!

Issue 36096: Layered Navigation does not filter products properly #36102

Are you sure you want to change the base?

Issue 36096: Layered Navigation does not filter products properly #36102

Uh oh!

Conversation

rogerdz commented Sep 7, 2022

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Sep 7, 2022

Uh oh!

rogerdz commented Sep 7, 2022

Uh oh!

magento-automated-testing bot commented Sep 7, 2022

Uh oh!

edenduong left a comment

Choose a reason for hiding this comment

Uh oh!

edenduong Sep 8, 2022

Choose a reason for hiding this comment

Uh oh!

edenduong Sep 8, 2022

Choose a reason for hiding this comment

Uh oh!

edenduong Sep 8, 2022

Choose a reason for hiding this comment

Uh oh!

edenduong Sep 8, 2022

Choose a reason for hiding this comment

Uh oh!

edenduong Sep 8, 2022

Choose a reason for hiding this comment

Uh oh!

edenduong Sep 8, 2022

Choose a reason for hiding this comment

Uh oh!

Den4ik Sep 13, 2022

Choose a reason for hiding this comment

Uh oh!

khnaim commented Oct 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

khnaim commented Oct 3, 2022 •

edited

Loading