Api interfaces mark 1 #32135

mrtuvn · 2021-02-12T12:04:28Z

Description (*)

Marked following interfaces as API

lib/internal/Magento/Framework/Amqp/Topology/BindingInstallerInterface.php
lib/internal/Magento/Framework/Api/AttributeTypeResolverInterface.php
lib/internal/Magento/Framework/Api/CriteriaInterface.php
lib/internal/Magento/Framework/Api/Search/AggregationInterface.php
lib/internal/Magento/Framework/Api/Search/AggregationValueInterface.php
lib/internal/Magento/Framework/Api/Search/BucketInterface.php
lib/internal/Magento/Framework/Api/Search/DocumentInterface.php
lib/internal/Magento/Framework/Api/Search/ReportingInterface.php
lib/internal/Magento/Framework/Api/SearchCriteria/CollectionProcessor/ConditionProcessor/CustomConditionInterface.php
lib/internal/Magento/Framework/Api/SearchCriteria/CollectionProcessor/ConditionProcessor/CustomConditionProviderInterface.php
lib/internal/Magento/Framework/Api/SimpleBuilderInterface.php
lib/internal/Magento/Framework/App/Action/HttpConnectActionInterface.php
lib/internal/Magento/Framework/App/Action/HttpDeleteActionInterface.php
lib/internal/Magento/Framework/App/Action/HttpGetActionInterface.php
lib/internal/Magento/Framework/App/Action/HttpOptionsActionInterface.php
lib/internal/Magento/Framework/App/Action/HttpPatchActionInterface.php
lib/internal/Magento/Framework/App/Action/HttpPostActionInterface.php
lib/internal/Magento/Framework/App/Action/HttpPropfindActionInterface.php
lib/internal/Magento/Framework/App/Action/HttpPutActionInterface.php
lib/internal/Magento/Framework/App/Action/HttpTraceActionInterface.php
lib/internal/Magento/Framework/App/AreaInterface.php
lib/internal/Magento/Framework/App/Config/CommentInterface.php
lib/internal/Magento/Framework/App/Config/CommentParserInterface.php
lib/internal/Magento/Framework/App/Config/ConfigResource/ConfigInterface.php
lib/internal/Magento/Framework/App/Config/ConfigSourceInterface.php
lib/internal/Magento/Framework/App/Config/ConfigTypeInterface.php
lib/internal/Magento/Framework/App/Config/Reader/Source/SourceInterface.php
lib/internal/Magento/Framework/App/Config/Scope/ReaderInterface.php
lib/internal/Magento/Framework/App/Config/Spi/PostProcessorInterface.php
lib/internal/Magento/Framework/App/Config/Spi/PreProcessorInterface.php

References class/interfaces also marked api
lib/internal/Magento/Framework/MessageQueue/Topology/Config/ExchangeConfigItem/BindingInterface.php

Related Pull Requests

Fixed Issues (if relevant)

Fixes Mark Framework interfaces as API part 1 #32024

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2021-02-12T12:04:30Z

Hi @mrtuvn. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

mrtuvn · 2021-02-18T14:49:35Z

rebased 2.5-develop

mrtuvn · 2021-02-19T04:57:49Z

@magento run all tests

mrtuvn · 2021-02-20T07:35:37Z

Fixed static tests
@magento run all tests

mrtuvn · 2021-02-20T09:46:14Z

@magento run WebAPI Tests, Functional Tests B2B

hws47a · 2021-02-20T16:59:52Z

...ernal/Magento/Framework/MessageQueue/Topology/Config/ExchangeConfigItem/BindingInterface.php

@@ -7,6 +7,8 @@

 /**
 * Instances of this interface represent config binging items declared in etc/queue_topology.xsd
+ *
+ * @api


Hi @mrtuvn,

Could you please share why this class is also marked as @api?

https://github.com/magento/magento2/blob/2.4-develop/lib/internal/Magento/Framework/Amqp/Topology/BindingInstallerInterface.php <= this class need marked api as purpose of this PR. When you see content this interface you can find this interface reference to another Magento\Framework\MessageQueue\Topology\Config\ExchangeConfigItem\BindingInterface (non-api)
So we also need mark this interface referenced to api too

You can see info interface listed in description

magento-engcom-team · 2021-02-21T19:03:28Z

Hi @hws47a, thank you for the review.
ENGCOM-8802 has been created to process this Pull Request
✳️ @hws47a, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

mrtuvn · 2021-04-03T01:47:26Z

Re-targeted PR branch to 2.4-develop as internal discussed with @gabrieldagama

update

mrtuvn · 2021-04-03T12:50:49Z

@magento run all tests

mrtuvn · 2021-04-03T21:07:17Z

@magento run WebAPI Tests

gabrieldagama · 2021-04-13T10:07:31Z

@magento import code to https://github.com/magento-engcom/magento2ce

magento-engcom-team · 2021-04-13T10:09:55Z

@gabrieldagama the branch with code successfully imported intomagento-engcom/magento2ce repository. Branch name: imported-magento-magento2-32135.

m2-assistant · 2021-04-13T15:10:47Z

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Feb 12, 2021

magento-engcom-team added Component: Amqp Component: Api Use with concrete module component label E.g. "Component: Api" + "Catalog" Component: App Component: CustomerImportExport Component: ImportExport Release Line: 2.4 labels Feb 12, 2021

m2-community-project bot added the Progress: pending review label Feb 12, 2021

mrtuvn changed the base branch from 2.4-develop to 2.5-develop February 12, 2021 12:04

gabrieldagama added this to the 2.5 milestone Feb 18, 2021

mrtuvn force-pushed the api-interfaces-mark-1 branch from 2ae4fb3 to cf3bebb Compare February 18, 2021 14:49

mrtuvn force-pushed the api-interfaces-mark-1 branch from cf3bebb to 1019b91 Compare February 20, 2021 07:35

hws47a self-requested a review February 20, 2021 16:54

hws47a reviewed Feb 20, 2021

View reviewed changes

m2-community-project bot assigned hws47a Feb 20, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Feb 20, 2021

hws47a approved these changes Feb 21, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Feb 21, 2021

magento-engcom-team removed Component: CustomerImportExport Component: ImportExport labels Feb 21, 2021

hws47a added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Feb 21, 2021

mrtuvn mentioned this pull request Feb 22, 2021

Mark Framework Interfaces as API part 3 #32156

Merged

4 tasks

m2-community-project bot added Progress: ready for testing and removed Progress: testing in progress labels Mar 31, 2021

Mark Framework interfaces as API part 1

61f8d7e

update

mrtuvn force-pushed the api-interfaces-mark-1 branch from 1019b91 to 61f8d7e Compare April 3, 2021 02:04

mrtuvn changed the base branch from 2.5-develop to 2.4-develop April 3, 2021 02:05

mrtuvn added Release Line: 2.4 and removed Release Line: 2.5 labels Apr 3, 2021

mrtuvn removed this from the 2.5 milestone Apr 3, 2021

m2-community-project bot removed the Progress: ready for testing label Apr 5, 2021

engcom-Oscar added Progress: ready for testing QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope labels Apr 5, 2021

m2-community-project bot added Progress: extended testing and removed Progress: ready for testing labels Apr 5, 2021

engcom-Foxtrot self-assigned this Apr 5, 2021

m2-community-project bot added Progress: ready for testing Progress: accept and removed Progress: extended testing Progress: ready for testing labels Apr 5, 2021

gabrieldagama changed the base branch from 2.4-develop to api-changes-develop April 13, 2021 10:06

m2-community-project bot added Progress: ready for testing and removed Progress: accept labels Apr 13, 2021

m2-community-project bot added Progress: accept and removed Progress: ready for testing labels Apr 13, 2021

magento-cicd2 merged commit b4dc47a into magento:api-changes-develop Apr 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Api interfaces mark 1 #32135

Api interfaces mark 1 #32135

Uh oh!

mrtuvn commented Feb 12, 2021 •

edited

Loading

Uh oh!

m2-assistant bot commented Feb 12, 2021

Uh oh!

mrtuvn commented Feb 18, 2021

Uh oh!

mrtuvn commented Feb 19, 2021

Uh oh!

mrtuvn commented Feb 20, 2021

Uh oh!

mrtuvn commented Feb 20, 2021

Uh oh!

hws47a Feb 20, 2021

Uh oh!

mrtuvn Feb 21, 2021 •

edited

Loading

Uh oh!

mrtuvn Feb 21, 2021

Uh oh!

magento-engcom-team commented Feb 21, 2021

Uh oh!

mrtuvn commented Apr 3, 2021

Uh oh!

mrtuvn commented Apr 3, 2021

Uh oh!

mrtuvn commented Apr 3, 2021

Uh oh!

gabrieldagama commented Apr 13, 2021

Uh oh!

magento-engcom-team commented Apr 13, 2021

Uh oh!

m2-assistant bot commented Apr 13, 2021

Uh oh!

Uh oh!

Api interfaces mark 1 #32135

Api interfaces mark 1 #32135

Uh oh!

Conversation

mrtuvn commented Feb 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Feb 12, 2021

Uh oh!

mrtuvn commented Feb 18, 2021

Uh oh!

mrtuvn commented Feb 19, 2021

Uh oh!

mrtuvn commented Feb 20, 2021

Uh oh!

mrtuvn commented Feb 20, 2021

Uh oh!

hws47a Feb 20, 2021

Choose a reason for hiding this comment

Uh oh!

mrtuvn Feb 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrtuvn Feb 21, 2021

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Feb 21, 2021

Uh oh!

mrtuvn commented Apr 3, 2021

Uh oh!

mrtuvn commented Apr 3, 2021

Uh oh!

mrtuvn commented Apr 3, 2021

Uh oh!

gabrieldagama commented Apr 13, 2021

Uh oh!

magento-engcom-team commented Apr 13, 2021

Uh oh!

m2-assistant bot commented Apr 13, 2021

Uh oh!

Uh oh!

mrtuvn commented Feb 12, 2021 •

edited

Loading

mrtuvn Feb 21, 2021 •

edited

Loading