Fix missing escape Url method #30008

mrtuvn · 2020-09-11T17:54:10Z

Description (*)

Correct missing escape url in layout template module widget

Related Pull Requests

Fixed Issues (if relevant)

Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

Go to Admin
Go Content > Elements > Widgets
Edit one exists widget
Page should load without break
Add layout update should work

For test edit widget add/delete "Layout Updates" we need merge the PR #29991 first

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Fix missing escape Url method #30036: Fix missing escape Url method

m2-assistant · 2020-09-11T17:54:13Z

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

rogyar · 2020-09-12T12:02:48Z

@magento run all tests

sidolov · 2020-09-14T14:54:12Z

@magento create issue

sidolov

@mrtuvn could you please cover changes with automated test?

mrtuvn · 2020-09-14T23:29:37Z

@sidolov i'm not sure how to start a test with such case
@engcom-Alfa @engcom-Charlie can you give any suggest on test cover?

mrtuvn · 2020-09-16T05:40:22Z

@magento give me test instance

magento-deployment-service · 2020-09-16T05:40:25Z

Hi @mrtuvn. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2020-09-16T05:44:48Z

Hi @mrtuvn, here is your Magento Instance: https://d157d14bc4d8fce469c45ab283b2dd75.instances.magento-community.engineering
Admin access: https://d157d14bc4d8fce469c45ab283b2dd75.instances.magento-community.engineering/admin_307a
Login: 5aaa0629
Password: 1744155a86f3

engcom-Charlie · 2020-09-16T09:03:56Z

@mrtuvn you can write an integration test on the block which uses a template changed by this PR and checks if the additional code is present.
Thank you.

mrtuvn · 2020-09-18T15:41:33Z

@engcom-Charlie Can you help with cover by mftf ? I'm not familiar with mftf test

engcom-Charlie · 2020-09-21T08:35:36Z

@mrtuvn Here is all information https://devdocs.magento.com/mftf/docs/introduction.html. If you will have any questions, let me know.
Thank you.

mrtuvn · 2020-09-28T14:50:53Z

@magento run all tests
I think no need cover this PR with automated tests. Instead we can manually test. This file used in admin area so it's will not affected or impact to another area

engcom-Charlie · 2020-09-29T10:59:43Z

@mrtuvn can you please add additional info on how to reproduce the issue manually and expected/actual results?
Thank you.

up fix static tests

mrtuvn · 2020-09-30T16:06:11Z

rebase branch with latest mainline code base + add fix static tests

engcom-Charlie · 2020-10-01T12:40:58Z

@mrtuvn I'll take care of test coverage.

engcom-Charlie · 2020-10-01T12:48:50Z

@magento run all tests

magento-engcom-team · 2020-10-06T12:28:41Z

Hi @sivaschenko, thank you for the review.
ENGCOM-8312 has been created to process this Pull Request
✳️ @sivaschenko, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

sivaschenko · 2020-10-06T12:31:48Z

QA: Please consider including #29991 during testing if needed to unblock required scenarios

engcom-Bravo · 2020-10-06T14:42:02Z

✔️ QA Passed

Layout Update can be added successfully and displayed correctly. Tested for a new Widget and editing an already existing one

Manual testing scenario

Go to Content - Widgets. Click Add Widget
Select for example
Type - CMS Page Link
Design Theme - Magento Blank
click Continue
Add several Layout Updates
Specify different Diaplay on, Products, Container, Template for each added Layout Update
Assert that all the Layout Updates are displayed correctly

Actual result

NOTE that the bug with Deleting is not fixed in this PR

engcom-Bravo · 2020-10-06T14:54:00Z

Further investigation discovered that if there are a lot of Layout Updates added, and after the web page is refreshed, it's taking some time for the options to load

@sivaschenko @sidolov Please see if this is acceptable

m2-assistant · 2020-10-07T20:18:05Z

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

ghost added the Progress: pending review label Sep 11, 2020

magento-engcom-team added Area: Frontend Component: Widget Release Line: 2.4 labels Sep 11, 2020

mrtuvn force-pushed the fix-missing-escape-url-method branch from 016b943 to 28d2d9e Compare September 11, 2020 17:56

rogyar self-assigned this Sep 12, 2020

sidolov added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Sep 14, 2020

m2-assistant bot mentioned this pull request Sep 14, 2020

[Issue] Fix missing escape Url method #30036

Closed

sidolov requested changes Sep 14, 2020

View reviewed changes

ghost assigned sidolov Sep 14, 2020

ghost added Progress: needs update and removed Progress: pending review labels Sep 14, 2020

engcom-Charlie self-assigned this Sep 16, 2020

mrtuvn force-pushed the fix-missing-escape-url-method branch from 28d2d9e to acf5fa6 Compare September 22, 2020 16:28

Fix missing escape url method

777c7c7

up fix static tests

mrtuvn force-pushed the fix-missing-escape-url-method branch from acf5fa6 to 777c7c7 Compare September 30, 2020 16:05

url escape test coverage

5f69036

engcom-Charlie requested a review from sidolov October 2, 2020 07:00

ghost added Progress: pending review Progress: review and removed Progress: needs update Progress: pending review labels Oct 2, 2020

sivaschenko approved these changes Oct 6, 2020

View reviewed changes

ghost assigned sivaschenko Oct 6, 2020

ghost added Progress: ready for testing and removed Progress: review labels Oct 6, 2020

sivaschenko added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Oct 6, 2020

engcom-Bravo self-assigned this Oct 6, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Oct 6, 2020

sivaschenko mentioned this pull request Oct 6, 2020

Fix issue when can't remove layout update after add during new widget creation #29991

Merged

4 tasks

engcom-Bravo added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Oct 6, 2020

ghost added Progress: extended testing Progress: accept and removed Progress: testing in progress Progress: extended testing labels Oct 6, 2020

magento-engcom-team pushed a commit that referenced this pull request Oct 7, 2020

ENGCOM-8312: Fix missing escape Url method #30008

92e2ff8

magento-engcom-team merged commit f96b45e into magento:2.4-develop Oct 7, 2020

mrtuvn deleted the fix-missing-escape-url-method branch October 13, 2020 14:06

Fix missing escape Url method #30008

Fix missing escape Url method #30008

Uh oh!

Conversation

mrtuvn commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Sep 11, 2020

Uh oh!

rogyar commented Sep 12, 2020

Uh oh!

sidolov commented Sep 14, 2020

Uh oh!

sidolov left a comment

Choose a reason for hiding this comment

Uh oh!

mrtuvn commented Sep 14, 2020

Uh oh!

mrtuvn commented Sep 16, 2020

Uh oh!

magento-deployment-service bot commented Sep 16, 2020

Uh oh!

magento-deployment-service bot commented Sep 16, 2020

Uh oh!

engcom-Charlie commented Sep 16, 2020

Uh oh!

mrtuvn commented Sep 18, 2020

Uh oh!

engcom-Charlie commented Sep 21, 2020

Uh oh!

mrtuvn commented Sep 28, 2020

Uh oh!

engcom-Charlie commented Sep 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrtuvn commented Sep 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

engcom-Charlie commented Oct 1, 2020

Uh oh!

engcom-Charlie commented Oct 1, 2020

Uh oh!

magento-engcom-team commented Oct 6, 2020

Uh oh!

sivaschenko commented Oct 6, 2020

Uh oh!

engcom-Bravo commented Oct 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Manual testing scenario

Actual result

Uh oh!

engcom-Bravo commented Oct 6, 2020

Uh oh!

m2-assistant bot commented Oct 7, 2020

Uh oh!

Uh oh!

mrtuvn commented Sep 11, 2020 •

edited

Loading

engcom-Charlie commented Sep 29, 2020 •

edited

Loading

mrtuvn commented Sep 30, 2020 •

edited

Loading

engcom-Bravo commented Oct 6, 2020 •

edited

Loading