Skip to content

PageCache / Layout: Avoid multiple calls and config fetch #28992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented Jul 4, 2020

Description (*)

Reduce the number of calls to Cache config.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] PageCache / Layout: Avoid multiple calls and config fetch #29159: PageCache / Layout: Avoid multiple calls and config fetch

@m2-assistant
Copy link

m2-assistant bot commented Jul 4, 2020

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

@lbajsarowicz lbajsarowicz force-pushed the improvement/layout-plugin branch from ac3ed4c to b59dc72 Compare July 4, 2020 00:29
@ihor-sviziev ihor-sviziev self-assigned this Jul 4, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jul 4, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7780 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

✔️ QA passed
Was checked pages are loaded without errors and number of calls to Cache config was reduced (execution time from 0.051918983459473 to 0.044523000717163) on catefory page
Before:
#28992Main

After
#28992PRtime

@engcom-Kilo engcom-Kilo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jul 13, 2020
@ihor-sviziev
Copy link
Contributor

@engcom-Delta wow. Quite significant diff!

@VladimirZaets
Copy link
Contributor

@magento create issue

@ghost ghost added Severity: S1 Affects critical data or functionality and forces users to employ a workaround. Priority: P3 May be fixed according to the position in the backlog. labels Jul 16, 2020
@engcom-Delta engcom-Delta added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jul 24, 2020
@slavvka slavvka removed the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label Jul 24, 2020
@magento-engcom-team magento-engcom-team merged commit 1a8da55 into magento:2.4-develop Aug 1, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 1, 2020

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: PageCache improvement Partner: Blue Acorn iCi partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Issue] PageCache / Layout: Avoid multiple calls and config fetch
7 participants