Skip to content

improve NonComposerComponentRegistration #28975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2020
Merged

improve NonComposerComponentRegistration #28975

merged 1 commit into from
Aug 1, 2020

Conversation

rvitaliy
Copy link
Member

@rvitaliy rvitaliy commented Jul 2, 2020 •
edited by slavvka
Loading

Description (*)

enable strict mode and added typeHint, this changes make execution of code more secure.
remove useless assignation $main.

Related Pull Requests

none

Fixed Issues

none

Manual testing scenarios (*)

not necessary, if CI passes this code is good, it's only technical improvement.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] improve NonComposerComponentRegistration #29308: improve NonComposerComponentRegistration

@m2-assistant
Copy link

m2-assistant bot commented Jul 2, 2020

Hi @rvitaliy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@rvitaliy
Copy link
Member Author

rvitaliy commented Jul 2, 2020

@magento run all tests

@ihor-sviziev ihor-sviziev self-assigned this Jul 3, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Jul 3, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7781 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@rvitaliy thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Delta engcom-Delta self-assigned this Jul 27, 2020
@engcom-Delta
Copy link
Contributor

Notice: QA not applicable

@engcom-Charlie engcom-Charlie self-assigned this Jul 27, 2020
@engcom-Charlie engcom-Charlie added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jul 27, 2020
@engcom-Delta
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jul 28, 2020
Closed
@engcom-Delta engcom-Delta added Component: Other QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jul 28, 2020
@sdzhepa sdzhepa added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Jul 29, 2020
@VladimirZaets
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jul 29, 2020
Closed
5 tasks
magento-engcom-team pushed a commit that referenced this pull request Aug 1, 2020
@slavvka
ENGCOM-7781: improve NonComposerComponentRegistration #28975
878c617
@magento-engcom-team magento-engcom-team merged commit 06c5a5d into magento:2.4-develop Aug 1, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 1, 2020

Hi @rvitaliy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Charlie engcom-Charlie

@engcom-Delta engcom-Delta

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] improve NonComposerComponentRegistration
7 participants
@rvitaliy @magento-engcom-team @engcom-Delta @VladimirZaets @ihor-sviziev @sdzhepa @engcom-Charlie