[MFTF] Use action group go to ProductCatalogPage #28941

Usik2203 · 2020-06-30T19:46:11Z

This PR uses AdminProductCatalogPageOpenActionGroup go to ProductCatalogPage instead
<amOnPage url="{{ProductCatalogPage.url}}" stepKey="GoToCatalogPageChangingView"/>
<waitForPageLoad stepKey="WaitForPageToLoadFullyChangingView"/>

m2-assistant · 2020-06-30T19:46:14Z

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

Usik2203 · 2020-06-30T19:46:46Z

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

eduard13

Good catch, however lets follow the camelCase naming convention here and use a lower case for the 1st letter. Please implement the same changes to all the places in this PR.
Thank you.

eduard13 · 2020-07-01T05:45:50Z

app/code/Magento/Bundle/Test/Mftf/Test/MassEnableDisableBundleProductsTest.xml

@@ -130,8 +130,7 @@
        <dontSeeElement stepKey="LookingForNameOfProductDisabled" selector="{{StorefrontBundledSection.bundleProductName}}"/>

        <!--Enabling bundle products-->
-        <amOnPage url="{{ProductCatalogPage.url}}" stepKey="GoToCatalogPageChangingView"/>
-        <waitForPageLoad stepKey="WaitForPageToLoadFullyChangingView"/>
+        <actionGroup ref="AdminProductCatalogPageOpenActionGroup" stepKey="GoToCatalogPageChangingView"/>


Lets following the camelcase format, the 1st letter should be a lowercase.

Suggested change

<actionGroup ref="AdminProductCatalogPageOpenActionGroup" stepKey="GoToCatalogPageChangingView"/>

<actionGroup ref="AdminProductCatalogPageOpenActionGroup" stepKey="goToCatalogPageChangingView"/>

eduard13 · 2020-07-01T05:46:02Z

app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductCatalogPageOpenActionGroup.xml

+            <description>Goes to the Admin Product Catalog Page grid page.</description>
+        </annotations>
+
+        <amOnPage url="{{ProductCatalogPage.url}}" stepKey="OpenProductCatalogPage"/>


Suggested change

<amOnPage url="{{ProductCatalogPage.url}}" stepKey="OpenProductCatalogPage"/>

<amOnPage url="{{ProductCatalogPage.url}}" stepKey="openProductCatalogPage"/>

Usik2203 · 2020-07-01T08:29:08Z

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

Usik2203 · 2020-07-01T14:37:43Z

@magento run Functional Tests B2B

eduard13

Awesome 👍

eduard13 · 2020-07-02T10:18:17Z

@magento run all tests

Usik2203 · 2020-07-03T08:44:15Z

@magento run Adobe CLA Signed

m2-assistant · 2020-07-03T08:45:00Z

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

eduard13 · 2020-07-03T08:46:33Z

The failing tests don't seem to be related to the PR changes.

magento-engcom-team · 2020-07-06T07:48:42Z

Hi @eduard13, thank you for the review.
ENGCOM-7783 has been created to process this Pull Request

engcom-Alfa · 2020-07-09T09:54:10Z

QA not applicable

m2-assistant · 2020-07-11T17:23:28Z

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Use action group go to ProductCatalogPage

ca5c26d

ghost added the Progress: pending review label Jun 30, 2020

magento-engcom-team added Component: Bundle Component: Catalog Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jun 30, 2020

eduard13 self-assigned this Jun 30, 2020

eduard13 requested changes Jul 1, 2020

View reviewed changes

ghost added Progress: needs update and removed Progress: pending review labels Jul 1, 2020

eduard13 added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jul 1, 2020

use camelCase name in stepName

ddc5f20

eduard13 approved these changes Jul 2, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Jul 2, 2020

Usik2203 closed this Jul 3, 2020

Usik2203 reopened this Jul 3, 2020

ghost added Progress: pending review and removed Progress: ready for testing labels Jul 3, 2020

ghost unassigned eduard13 Jul 3, 2020

eduard13 self-assigned this Jul 3, 2020

eduard13 approved these changes Jul 6, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: pending review labels Jul 6, 2020

engcom-Alfa self-assigned this Jul 9, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Jul 9, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Jul 9, 2020

engcom-Echo self-assigned this Jul 9, 2020

engcom-Charlie assigned engcom-Charlie and unassigned engcom-Echo Jul 9, 2020

engcom-Echo assigned engcom-Echo and unassigned engcom-Charlie Jul 9, 2020

ghost added Progress: accept and removed Progress: extended testing labels Jul 9, 2020

slavvka added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jul 9, 2020

slavvka added this to the 2.4.1 milestone Jul 9, 2020

magento-engcom-team pushed a commit that referenced this pull request Jul 11, 2020

ENGCOM-7783: [MFTF] Use action group go to ProductCatalogPage #28941

5e88aa7

magento-engcom-team merged commit b6698f5 into magento:2.4-develop Jul 11, 2020

	<actionGroup ref="AdminProductCatalogPageOpenActionGroup" stepKey="GoToCatalogPageChangingView"/>
	<actionGroup ref="AdminProductCatalogPageOpenActionGroup" stepKey="goToCatalogPageChangingView"/>

	<amOnPage url="{{ProductCatalogPage.url}}" stepKey="OpenProductCatalogPage"/>
	<amOnPage url="{{ProductCatalogPage.url}}" stepKey="openProductCatalogPage"/>

[MFTF] Use action group go to ProductCatalogPage #28941

[MFTF] Use action group go to ProductCatalogPage #28941

Uh oh!

Conversation

Usik2203 commented Jun 30, 2020

Uh oh!

m2-assistant bot commented Jun 30, 2020

Uh oh!

Usik2203 commented Jun 30, 2020

Uh oh!

eduard13 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eduard13 Jul 1, 2020

Choose a reason for hiding this comment

Uh oh!

Usik2203 Jul 1, 2020

Choose a reason for hiding this comment

Uh oh!

eduard13 Jul 1, 2020

Choose a reason for hiding this comment

Uh oh!

Usik2203 Jul 1, 2020

Choose a reason for hiding this comment

Uh oh!

Usik2203 commented Jul 1, 2020

Uh oh!

Usik2203 commented Jul 1, 2020

Uh oh!

eduard13 left a comment

Choose a reason for hiding this comment

Uh oh!

eduard13 commented Jul 2, 2020

Uh oh!

Usik2203 commented Jul 3, 2020

Uh oh!

m2-assistant bot commented Jul 3, 2020

Uh oh!

eduard13 commented Jul 3, 2020

Uh oh!

magento-engcom-team commented Jul 6, 2020

Uh oh!

engcom-Alfa commented Jul 9, 2020

Uh oh!

m2-assistant bot commented Jul 11, 2020

Uh oh!

Uh oh!

eduard13 left a comment •

edited

Loading