Skip to content

[Forwardport] Using Media Image custom attribute type could not display on frontend. #19054 #20096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

davidverholen
Copy link
Member

Original Pull Request

#19068

Description (*)

Using Media Image custom attribute type could not display on frontend. #19054

Fixed Issues (if relevant)

  1. magento/magento2#Using Media Image custom attribute type could not display on frontend.  #19054: Using Media Image custom attribute type could not display on frontend
  2. ...

Manual testing scenarios (*)

  1. Create custom attribute named 'icon_image' of product from admin.
  2. Set attribute type Media Image.
  3. assign icon_image attribute in attribute set.
  4. Update product image and set new role 'icon_image'.
  5. In .phtml template ->
$productImageAttr = $product->getCustomAttribute( 'icon_image' );
$productImage = $this->helper('Magento\Catalog\Helper\Image')
->init($product, 'icon_image')
->setImageFile($productImageAttr->getValue());
<img src="<?php echo $productImage->getUrl() ?>" alt="<?php echo $block->escapeHtml($product->getTitle()) ?>" />

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @davidverholen. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Member

@rodrigowebjump rodrigowebjump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @davidverholen Thanks for your contribution.

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, thank you for the review.
ENGCOM-3797 has been created to process this Pull Request

@ghost
Copy link

ghost commented Jan 16, 2019

Hi @davidverholen, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @davidverholen. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@PsmIndia
Copy link

PsmIndia commented Aug 8, 2020

Hi, how i can print product image labels that i import with product, by default its showing it product name or alt tag? i just want to labels of product images like Big image label, thumbnail image label, small image label ? on product view page, please help me anyone ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants