Performance optimization by replacing is_null with === null #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-team
pushed a commit
that referenced
this pull request
Apr 3, 2015
[CICD] CRAP metric integration into CICD builds
okorshenko
pushed a commit
to isitnikov/magento2
that referenced
this pull request
Aug 10, 2016
…able [Performance] MAGETWO-54682: [Customer] Fast load of product options
taskula
pushed a commit
to Hypernova-Oy/magento2
that referenced
this pull request
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to
http://framework.zend.com/issues/browse/ZF-5413the usage of is_null is slow.So I replaced every occurrences of is_null or !is_null with === null or !== null
Unit test are running "normal".
First time for me, so I do accept your Contributor License Agreement.