Fix empty cart button

[luukschakenraad]

Description (*)

This commit fixes the empty cart button on the cart page. It was not working because of the selector in 'app/code/Magento/Checkout/view/frontend/web/js/shopping-cart.js:17':

$(this.options.emptyCartButton).on('click', $.proxy(function () {
                $(this.options.emptyCartButton).attr('name', 'update_cart_action_temp');
                $(this.options.updateCartActionContainer)
                    .attr('name', 'update_cart_action').attr('value', 'empty_cart');
            }, this));

this.options.emptyCartButton is set in app/code/Magento/Checkout/view/frontend/templates/cart/form.phtml:27:

data-mage-init='{"shoppingCart":{"emptyCartButton": "action.clear",

That selector should be .action.clear instead of action.clear to be able to select the empty-cart-button

Fixed Issues (if relevant)

#18589: Empty cart button does not work
#18475: "Clear Shopping Cart" in Magento Blank theme no longer working after 2.2.6

Manual testing scenarios (*)

1. Add a product to your cart
2. Go to the cart page
3. In the developer-console of your browser run jQuery('.action.clear').show(); to show the default "empty cart button"
4. Click the button "Clear shopping Cart"
5. The cart should now be cleared

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @luukschakenraad. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

@luukschakenraad thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[luukschakenraad]

@luukschakenraad thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

I just accepted the invitation, thank you.

[magento-engcom-team]

Hi @luukschakenraad. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.