Use route ID when creating secret keys in backend menus instead of route name

[lfolco]

Description

If you use a different route ID and front name in the adminhtml/routes.xml file, you will get redirected to the dashboard when clicking on the menu link.

This is because the route front name is used to generate the secret key when creating the menu, and route ID is used to generate the secret key for key validation.

The method \Magento\Backend\Model\Url::getSecretKey() takes three parameters: route ID, action path, and action. When creating links for the menu, Magento\Backend\Block\Menu::_callbackSecretKey($match) is reading the URL paths from XML, which are using front names. I have injected \Magento\Framework\App\Route\ConfigInterface in order to use getRouteByFrontName($routeName) in order to get the proper route ID.

Fixed Issues (if relevant)

1. Backend Security key broken for controllers with frontname not equal to route ID #7557: Backend Security key broken for controllers with front name not equal to route ID

Manual testing scenarios

1. Create a module with an adminhtml/routes.xml file that has a different route ID and front name.
2. Add an adminhtml/menu.xml file that uses the front name in the action attribute.
3. Click on the new menu link; you will be taken to the correct admin page.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @lfolco. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[miguelbalparda]

Thanks a lot Laura! I'll process this and let you know if we have any questions.

[magento-engcom-team]

Hi @miguelbalparda, thank you for the review.
ENGCOM-2838 has been created to process this Pull Request

[magento-engcom-team]

@lfolco thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[sidolov]

Please, inject new dependencies according to our Backward compatible development guide

[lfolco]

Please check now, I have committed the requested changes.

[magento-engcom-team]

Hi @lfolco. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.