Skip to content

[Forwardport] Link logo in web setup wizard to back-end base URL #17611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Forwardport] Link logo in web setup wizard to back-end base URL #17611

wants to merge 1 commit into from

Conversation

jignesh-baldha
Copy link
Member

Original Pull Request

#17543

Description

When you get to the web setup wizard from the Magento back-end it was not possible to get back to the back-end from this page.

This commit makes the logo clickable and when you click it you will return the Magento back-end.

Fixed Issues (if relevant)

  1. Sidebar shortcut to admin dashboard (Magento logo on top left) has no link in web setup wizard #13948:
    Sidebar shortcut to admin dashboard (Magento logo on top left) has no link in web setup wizard
  2. ...

Manual testing scenarios

  1. Admin dashboard > System > Web Setup Wizard
  2. Click Magento logo on top left
  3. You get back to admin dashboard

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

When you get to the web setup wizard from the Magento back-end it was
not possible to get back to the back-end from this page.

This commit makes the logo clickable and when you click it you will
return the Magento back-end.
@magento-engcom-team
Copy link
Contributor

Hi @jignesh-baldha. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov sidolov self-assigned this Aug 14, 2018
@sidolov
Copy link
Contributor

sidolov commented Aug 14, 2018

@jignesh-baldha , I'm closing this PR as a duplicate for #17610

@sidolov sidolov closed this Aug 14, 2018
@jignesh-baldha jignesh-baldha deleted the 2.3-develop-PR-port-17543 branch August 14, 2018 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants