Skip to content

[2.2] Fix - minicart label fixed size issue #14716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2018
Merged

[2.2] Fix - minicart label fixed size issue #14716

merged 2 commits into from
Apr 17, 2018

Conversation

Karlasa
Copy link
Contributor

@Karlasa Karlasa commented Apr 16, 2018

minicart qty label had fixed size and with longer translation phrases input field was covering label.

Description

Removed row with width attribute.

Manual testing scenarios

  1. Add product to cart
  2. change qty label text
  3. Longer labels overflows and goes under input field.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@VladimirZaets VladimirZaets self-assigned this Apr 16, 2018
@magento-engcom-team magento-engcom-team added this to the April 2018 milestone Apr 16, 2018
@magento-engcom-team magento-engcom-team merged commit 9f82c4f into magento:2.2-develop Apr 17, 2018
magento-engcom-team pushed a commit that referenced this pull request Apr 17, 2018
ENGCOM-1299: [2.2] Fix - minicart label fixed size issue #14716
bf39b51
@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

@Karlasa Karlasa deleted the minicart-less branch April 17, 2018 10:49
This was referenced Apr 17, 2018
Merged
Merged
magento-engcom-team added a commit that referenced this pull request Apr 17, 2018
@magento-engcom-team
ENGCOM-1309: [backport] #14716 Fix - minicart label fixed size issue #…
8f92765 
…14738

 - Merge Pull Request #14738 from Karlasa/magento2:PR-14716-backport
 - Merged commits:
   1. 3cc5b4d
   2. 59b2f4d
magento-engcom-team pushed a commit that referenced this pull request Apr 17, 2018
ENGCOM-1309: [backport] #14716 Fix - minicart label fixed size issue #…
82eb041 
…14738
magento-engcom-team added a commit that referenced this pull request Apr 17, 2018
@magento-engcom-team
🔃 [EngCom] Public Pull Requests - 2.1-develop
f582704 
Accepted Public Pull Requests:
 - #14738: [backport] #14716 Fix - minicart label fixed size issue (by @Karlasa)
 - #14736: [backport] #14669: Css class "empty" is always present on minicart dropdown (by @Karlasa)
magento-engcom-team added a commit that referenced this pull request Apr 17, 2018
@magento-engcom-team
ENGCOM-1310: [forwardport] #14716 Fix - minicart label fixed size issue
61da4b3 
#14739

 - Merge Pull Request #14739 from Karlasa/magento2:PR-14717-forwardport
 - Merged commits:
   1. 5dc7e02
   2. 5ed3cce
magento-engcom-team pushed a commit that referenced this pull request Apr 17, 2018
ENGCOM-1310: [forwardport] #14716 Fix - minicart label fixed size issue
4645dda 
#14739
magento-engcom-team added a commit that referenced this pull request Apr 17, 2018
@magento-engcom-team
🔃 [EngCom] Public Pull Requests - 2.3-develop
8820d4a 
Accepted Public Pull Requests:
 - #14739: [forwardport] #14716 Fix - minicart label fixed size issue (by @Karlasa)
 - #14737: [forwardport] #14669: Css class "empty" is always present on minicart dropdown (by @Karlasa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VladimirZaets VladimirZaets

Labels
Progress: accept Release Line: 2.2
Projects
None yet
Milestone
April 2018
Development

Successfully merging this pull request may close these issues.
3 participants
@Karlasa @magento-engcom-team @VladimirZaets