Products cart prices are shifted

[KhaledF]

I'm using Magento2 and I have successfully changed the final product price depending on the custom option value using Observer on catalog_product_get_final_price, and my product is configurable product,

my problem is when I add the same product to cart but with different custom options, the final prices are shifted by one and not attached to its right product.

I have run many tests and the products are loaded as: final product added to cart is the first one processed in Observer and then first one and so on, but only when the are same product.

Any one can help me in this issue? Thanks.

[veloraven]

@KhaledF thank you for your report.
Please, format this issue according to the Issue reporting guidelines: with steps to reproduce, actual result and expected result.
Please, also identify which version of Magento you are running.

[KhaledF]

Thanks,

• Preconditions:
  Configurable Product that has custom options: Height and Width.
  Customized observer listen to catalog_product_get_final_price event and modify final product price depends on the custom option Height and Width.
  Using Magento version 2.0.7 and upgraded to version 2.1.0

• Steps to reproduce:
  Adding the same product multi times but with different values in the custom option.

• Actual result:
  Correct price not attached to its corresponding product, but prices are shifted and products not shifted.
  And when debugging the sequence of processing the product, it starts with the last product added to cart but only if the same product is repeated and process products normally by it order of adding to cart if they are different product of that configurable product.

• Expected result:
  To attach each price with its product.

[KhaledF]

Ok.. I found that the problem is in:
module-configurable-product/Model/Product/Type/Configurable/Price.php
at the line:
$finalPrice = parent::getFinalPrice($qty, $product->getCustomOption('simple_product')->getProduct());

as the $product itself is different from returned value from $product->getCustomOption('simple_product')->getProduct() but that is only when it is the same configurable product but different options values.

So I edited the function and sent the correct product and then handled that issue in my observer.

[magento-engcom-team]

@KhaledF, thank you for your report.
Please use the issue reporting guidelines to report an issue. Please, edit issue description and include the preconditions, the steps required to reproduce, the actual result, and the expected result.
Please try to reproduce this issue on fresh and clean installation without any third-party dependencies.