Shipment email not sent when submitted from Admin Order view despite being enabled in store configuration

[rns-nonaka-enagic]

Preconditions and environment

• Magento version
  　2.4.7-p5
• Multi-store setup with different configurations for shipment emails
• Default store has shipment emails disabled
• Secondary store has shipment emails enabled

Steps to reproduce

1. Set up a multi-store configuration where the default store has shipment emails disabled
2. Create an order in a secondary store that has shipment emails enabled
3. Go to Admin > Sales > Orders
4. Open the order from the secondary store
5. Click on "Ship" button
6. Fill in shipment details and check "Email Copy of Shipment"
7. Submit the shipment

Expected result

The system should send a shipment confirmation email as it is enabled in the store configuration where the order was placed.

Actual result

No shipment confirmation email is sent because the system checks the default store configuration instead of the store configuration where the order was placed.

Additional information

Root cause analysis

In Save.php at line 170, the shipment email sending condition is checked using:

if (!empty($data['send_email']) && $this->salesData->canSendNewShipmentEmail())

The canSendNewShipmentEmail() method is called without passing the store ID parameter. This causes the system to check the configuration of the default store instead of the store where the order was placed.

The correct implementation should pass the order's store ID to this method:

if (!empty($data['send_email']) && $this->salesData->canSendNewShipmentEmail($shipment->getOrder()->getStoreId()))

This issue affects multi-store setups where different stores have different email configuration settings.

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @rns-nonaka-enagic. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Hello @rns-nonaka-enagic ,

Thank you for your report and collaboration.

We attempted to reproduce the issue in our latest version 2.4 develop but were unable to do so. Please find the attached screenshot for reference.

Steps to Reproduce:

Set up a multi-store configuration where the default store has shipment emails disabled.
Create an order in a secondary store that has shipment emails enabled.
Go to Admin > Sales > Orders.
Open the order from the secondary store.
Click on the "Ship" button.
Enter the required shipment details and check "Email Copy of Shipment."
Submit the shipment.

We followed the provided preconditions and steps but did not encounter any issues. Could you please recheck in the latest version of Magento and let us know if we are missing any steps to reproduce this issue?

Therefore, we are marking this ticket as "Issue: Needs Update."

Thank you!

[rns-nonaka-enagic]

@engcom-November
We have confirmed the issue on the 2.4.7-develop environment.
The detailed steps to reproduce are as follows:

First, create two stores.
In this example, we use "Main Store" and "US Store".
Please make sure to use a store from a different website.
This difference is likely the key factor determining whether the issue can be reproduced or not.
as the system will fall back to the settings of the Default Website, Default Store, and Default Store View.

Then, disable the Shipment email in the Main Website.

Enable the Shipment email in the US Website.

Next, place an order from the frontend.

After that, open the order in the backend and perform the shipment.

During the shipment, check the Email Copy of Shipment option and select Submit Shipment.
Note: The issue only occurs with this operation.

At this point, the Shipment email will not be sent, which confirms the problem.

Cause in the source code
The root cause is in the following file:
vendor/magento/module-shipping/Controller/Adminhtml/Order/Shipment/Save.php
Line 170

Since the Store ID is not specified, it falls back to the default store configuration.

[engcom-November]

Hello @rns-nonaka-enagic ,

Thank you for your report and collaboration.

We attempted to reproduce the issue in the latest 2.4-develop instances, We are able to reproduce the issue. Please refer to the attached screenshot for details.

Steps to Reproduce:

1. Create two stores.
2. Disable the Shipment email in the Main Website.
3. Enable the Shipment email in the US Website.
4. Place the order from frontend
5. In backend please perform the shipment.
6. During the shipment, check the Email Copy of Shipment option and select Submit Shipment.

We followed the preconditions and steps as provided and encountered the issue.

Therefore, we are marking this ticket as "Issue: Confirmed."

Thank you!