CategoryLinkReposity does not list all possible exceptions

[troendheim]

Summary (*)

The PHPDoc in https://github.com/magento/magento2/blob/2.3.0/app/code/Magento/Catalog/Api/CategoryLinkRepositoryInterface.php (delete and deleteByIds) does show the full list of exceptions that could be thrown.

I have checked and the issue exists in v2.2.7 and v2.3.0.

Examples (*)

https://github.com/magento/magento2/blob/2.3.0/app/code/Magento/Catalog/Model/CategoryLinkRepository.php#L81 throws InputException. Neither the method or the interface declares this through PHPDoc which can lead to surprises when using the repository.

Proposed solution

Add Magento\Framework\Exception to "throws" for the two methods

[magento-engcom-team]

Hi @troendheim. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@troendheim do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[magento-engcom-team]

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[magento-engcom-team]

@engcom-backlog-nazar Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-97398, MAGETWO-97399 were created

[orlangur]

@troendheim instead of reporting in such cases it's better to propose a pull request ;)

Thanks for collaboration!

[sidolov]

Hi @troendheim. Thank you for your report.
The issue has been fixed in #20050 by @pmclain in 2.3-develop branch
Related commit(s):

• d08ce919585c9f3e9020662eaf0948df260fbb4a
• a1d3299191805ea5fbee133436fe82ccb6b9a5cd

The fix will be available with the upcoming 2.3.1 release.