Fix phpmd issues that were false-positive

Author: karyna-t

app/code/Magento/Analytics/Test/Unit/ReportXml/SelectHydratorTest.php

@@ -198,7 +198,7 @@ public function testRecreateWithExpression(
             ->willReturn($this->selectMock);
         $withArgs = [];
 
-        foreach (array_keys($selectParts) as $key => $partName) {
+        foreach (array_keys($selectParts) as $partName) {
             $withArgs[] = [$partName, $expectedParts[$partName]];
         }
         $this->selectMock

app/code/Magento/Backend/Test/Unit/Controller/Adminhtml/System/Account/SaveTest.php

@@ -195,10 +195,7 @@ protected function setUp(): void
         $args = ['context' => $contextMock];
 
         $testHelper = new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this);
-        $this->controller = $testHelper->getObject(
-            Save::class,
-            $args
-        );
+        $this->controller = $testHelper->getObject(Save::class, $args);
     }
 
     /**

app/code/Magento/Bundle/Test/Unit/Model/Product/TypeTest.php

@@ -1383,8 +1383,7 @@ public function testPrepareForCartAdvancedAllRequiredOption(): void
                     'getBundleOption',
                     'getBundleOptionsData'
                 ]
-            )
-            ->disableOriginalConstructor()
+            )->disableOriginalConstructor()
             ->getMock();
         /* @var \PHPUnit\Framework\MockObject\MockObject|\Magento\Catalog\Model\Product\Option $option */
         $option = $this->getMockBuilder(Option::class)
@@ -1405,8 +1404,7 @@ public function testPrepareForCartAdvancedAllRequiredOption(): void
                     'hasData',
                     'getData'
                 ]
-            )
-            ->addMethods(['getHasOptions', 'setCartQty', 'getSkipCheckRequiredOption'])
+            )->addMethods(['getHasOptions', 'setCartQty', 'getSkipCheckRequiredOption'])
             ->disableOriginalConstructor()
             ->getMock();
         /** @var MockObject|Type $productType */
@@ -1419,7 +1417,6 @@ public function testPrepareForCartAdvancedAllRequiredOption(): void
             ->onlyMethods(['getItems'])
             ->disableOriginalConstructor()
             ->getMock();
-
         $this->parentClass($group, $option, $buyRequest, $product);
 
         $product->expects($this->any())
@@ -1444,7 +1441,6 @@ function ($key) use ($optionCollection) {
                             $resultValue = [0 => 5];
                             break;
                     }
-
                     return $resultValue;
                 }
             );
@@ -1456,8 +1452,7 @@ function ($key) use ($optionCollection) {
         $buyRequest->expects($this->once())
             ->method('getBundleOption')
             ->willReturn([3 => 5]);
-        $option
-            ->method('getId')
+        $option->method('getId')
             ->willReturnOnConsecutiveCalls(3);
         $option->expects($this->once())
             ->method('getRequired')

app/code/Magento/CacheInvalidate/Test/Unit/Model/PurgeCacheTest.php

@@ -91,7 +91,6 @@ public function testSendPurgeRequest(array $hosts): void
         $connectWithArgs = $writeWithArgs = [];
 
         foreach ($uris as $uri) {
-            $withArgs[] = [$uri->getHost(), $uri->getPort()];
             $writeWithArgs[] = ['PURGE', $uri, '1.1', ['X-Magento-Tags-Pattern' => 'tags', 'Host' => $uri->getHost()]];
         }
         $this->socketAdapterMock

app/code/Magento/Catalog/Test/Unit/Model/ProductRepositoryTest.php

@@ -551,7 +551,6 @@ public function testGetByIdProductInEditMode(): void
      */
     public function testGetByIdForCacheKeyGenerate($identifier, $editMode, $storeId): void
     {
-        $callIndex = 0;
         $this->productFactory
             ->expects($this->once())
             ->method('create')

app/code/Magento/Catalog/Test/Unit/Pricing/Render/FinalPriceBoxTest.php

@@ -113,10 +113,8 @@ protected function setUp(): void
 
         $eventManager = $this->createMock(ManagerStub::class);
         $this->layout = $this->createMock(Layout::class);
-
         $this->priceBox = $this->createMock(PriceBox::class);
         $this->logger = $this->getMockForAbstractClass(LoggerInterface::class);
-
         $this->layout->expects($this->any())->method('getBlock')->willReturn($this->priceBox);
 
         $cacheState = $this->getMockBuilder(StateInterface::class)

app/code/Magento/Customer/Test/Unit/Controller/Account/ConfirmTest.php

@@ -275,6 +275,7 @@ public function getParametersDataProvider(): array
      *
      * @return void
      * @dataProvider getSuccessMessageDataProvider
+     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      */
     public function testSuccessMessage(
         $customerId,

app/code/Magento/Customer/Test/Unit/Model/AccountManagementTest.php

@@ -1510,6 +1510,7 @@ public function testSendPasswordReminderEmail(): void
      * @param string $hash
      *
      * @return void
+     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      */
     protected function prepareInitiatePasswordReset(
         $email,

app/code/Magento/Customer/Test/Unit/Model/Plugin/SaveCustomerGroupExcludedWebsiteTest.php

@@ -23,6 +23,9 @@
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
+/**
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
 class SaveCustomerGroupExcludedWebsiteTest extends TestCase
 {
     /**

app/code/Magento/Elasticsearch/Test/Unit/Model/Adapter/ElasticsearchTest.php

@@ -104,6 +104,7 @@ class ElasticsearchTest extends TestCase
 
     /**
      * @inheritdoc
+     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      */
     protected function setUp(): void
     {

app/code/Magento/Email/Test/Unit/Model/Template/Config/FileIteratorTest.php

@@ -82,7 +82,6 @@ public function testIterator(): void
             '<template module="' . $moduleName . '" 321>'
         ];
         $index = 0;
-        $dirIndex = 0;
 
         $moduleDirResolverWithArgs = $moduleDirResolverWillReturnArgs = [];
         $fileReadFactoryWithArgs = $fileReadFactoryWillReturnArgs = [];

app/code/Magento/Reports/Test/Unit/Helper/DataTest.php

@@ -100,7 +100,7 @@ public function testPrepareIntervalsCollection($from, $to, $period, $results): v
 
         $withArgs = [];
 
-        foreach ($results as $key => $result) {
+        foreach ($results as $result) {
             $withArgs[] = [$result];
         }
         $item

app/code/Magento/Sales/Test/Unit/Controller/Adminhtml/Order/Create/ConfigureProductToAddTest.php

@@ -26,6 +26,8 @@
 
 /**
  * Tests for \Magento\Sales\Controller\Adminhtml\Order\Create\ConfigureProductToAdd
+ *
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class ConfigureProductToAddTest extends TestCase
 {

app/code/Magento/Sales/Test/Unit/Model/EmailSenderHandlerTest.php

@@ -26,6 +26,8 @@
 
 /**
  * Unit test of sales emails sending observer.
+ *
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class EmailSenderHandlerTest extends TestCase
 {
@@ -152,6 +154,7 @@ protected function setUp(): void
      *
      * @return void
      * @dataProvider executeDataProvider
+     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      */
     public function testExecute(
         int $configValue,

dev/tests/integration/framework/Magento/TestFramework/Annotation/IndexerDimensionMode.php

@@ -21,6 +21,7 @@
 
 /**
  * Implementation of the @magentoIndexerDimensionMode DocBlock annotation
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class IndexerDimensionMode
 {

dev/tests/integration/framework/tests/unit/testsuite/Magento/Test/ApplicationTest.php

@@ -23,6 +23,9 @@
 
 /**
  * Provides tests for \Magento\TestFramework\Application.
+ *
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ *
  */
 class ApplicationTest extends \PHPUnit\Framework\TestCase
 {

dev/tests/static/framework/tests/unit/testsuite/Magento/TestFramework/Integrity/Library/_files/DummyInjectableClass.php

@@ -10,6 +10,10 @@
 use Magento\Framework\DataObject;
 use TestNamespace\Some\SomeTestClass;
 
+/**
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+ * @SuppressWarnings(PHPMD.UnusedPrivateMethod)
+ */
 class DummyInjectableClass
 {
     public function testMethod(DataObject $dataObject, SomeTestClass $test)

lib/internal/Magento/Framework/Mview/Test/Unit/View/SubscriptionTest.php

@@ -24,6 +24,9 @@
 use ReflectionException;
 use ReflectionMethod;
 
+/**
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
 class SubscriptionTest extends TestCase
 {
     /**