Skip to content

Commit 8273de6

Browse files
committed
Fix phpstan issues that were false-positive
1 parent 6950895 commit 8273de6

File tree

5 files changed

+7
-4
lines changed

5 files changed

+7
-4
lines changed

app/code/Magento/Catalog/Test/Unit/Pricing/Price/CustomOptionPriceTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,7 @@ public function testGetSelectedOptions(): void
400400

401401
// Return from cache
402402
$result = $this->object->getSelectedOptions();
403-
$this->equalTo($optionValue, $result);
403+
$this->assertEquals($optionValue, $result);
404404
}
405405

406406
/**

app/code/Magento/Directory/Setup/Patch/Data/AddDataForIndia.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,9 @@ public function __construct(
4242
}
4343

4444
/**
45-
* @inheritdoc
45+
* Run code inside patch
46+
*
47+
* @return void
4648
*/
4749
public function apply()
4850
{

app/code/Magento/GroupedProduct/Test/Unit/Model/Product/Type/Grouped/PriceTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,7 @@ protected function generateAssociatedProducts(): array
207207
/* price for option taking into account quantity discounts */
208208
$childProductMock->expects($this->any())->method('getFinalPrice')->with(5)->willReturn(5);
209209

210+
$associatedProducts = [];
210211
for ($i = 0; $i <= 2; $i++) {
211212
$childProduct = clone $childProductMock;
212213
$childProduct->expects($this->once())->method('getId')->willReturn($i);

lib/internal/Magento/Framework/Mview/Test/Unit/View/SubscriptionTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,6 @@ protected function setUp(): void
124124
]
125125
]
126126
]);
127-
$this->mviewConfig = $mviewConfigMock;
128127
$this->model = new Subscription(
129128
$this->resourceMock,
130129
$this->triggerFactoryMock,

setup/src/Magento/Setup/Test/Unit/Model/PhpReadinessCheckTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -467,7 +467,7 @@ protected function isPhp7OrHhvm(): bool
467467

468468
/**
469469
* @param $param
470-
* @return int|string
470+
* @return int|string|bool
471471
*/
472472
function ini_get($param)
473473
{
@@ -478,4 +478,5 @@ function ini_get($param)
478478
} elseif ($param === 'memory_limit') {
479479
return '512M';
480480
}
481+
return false;
481482
}

0 commit comments

Comments
 (0)