955 add missing title to form #956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilinMykola
force-pushed
the
955-add-missing-title-to-form
branch
from
23c60ef to
2359033
Compare
eduard13
requested changes
Feb 3, 2022
There was a problem hiding this comment.
Hi @SilinMykola, thank you for the fix, may I ask you to also adjust the title for Models modal? The single form should be used: models -> model.
Thank you.
|
Hi @eduard13 ! Thanks for your review. I changed a title for the Model form. |
SilinMykola
force-pushed
the
955-add-missing-title-to-form
branch
from
2359033 to
60f239e
Compare
bohdan-harniuk
approved these changes
Feb 5, 2022
There was a problem hiding this comment.
Hello, @SilinMykola!
Thank you for your contribution and for fixing after @eduard13 review.
m2-community-project
bot
added
Progress: approved
and removed
Progress: changes requested
labels
|
Hello, @eduard13! Please, check the PR. It is fixed. Regards, |
eduard13
approved these changes
Feb 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
I added missed titles to some forms.
Magento 2 Email Template form:
and Magento 2 Models form:
Fixed Issues (if relevant)
Questions or comments
Contribution checklist (*)