Skip to content

Added source model generation for EAV attribute input #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 9, 2021
Merged

Added source model generation for EAV attribute input #534

merged 3 commits into from
Apr 9, 2021

Conversation

ProkopovVitaliy
Copy link
Contributor

Description (*)

Added possibilities choose or generate source model according to eav attribute input.
Screenshot 2021-04-09 at 15 26 20

  1. Generate product attribute data patch without source model:
Apr-09-2021.15-48-09.mp4
  1. Choose source model for some inputs:
Apr-09-2021.15-47-48.mp4
  1. Generate source model:
Apr-09-2021.15-47-22.mp4
with_custom_path.mp4

Fixed Issues (if relevant)

  1. Fixes Source model generation for EAV attribute input #532

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@VitaliyBoyko VitaliyBoyko self-assigned this Apr 9, 2021
VitaliyBoyko
VitaliyBoyko reviewed Apr 9, 2021
View reviewed changes
src/com/magento/idea/magento2plugin/magento/packages/eav/AttributeInput.java
@@ -5,24 +5,24 @@

package com.magento.idea.magento2plugin.magento.packages.eav;

public enum AttributeInputs {
public enum AttributeInput {
TEXT("text"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice sorting

VitaliyBoyko
VitaliyBoyko requested changes Apr 9, 2021
View reviewed changes
@ProkopovVitaliy
Copy link
Contributor Author

@VitaliyBoyko copyright added for all mentioned files.

Thanks!

@VitaliyBoyko VitaliyBoyko self-requested a review April 9, 2021 13:40
VitaliyBoyko
VitaliyBoyko approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@VitaliyBoyko VitaliyBoyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Thank you @ProkopovVitaliy

@VitaliyBoyko VitaliyBoyko merged commit c75f0d4 into magento:mainline-eav-attr-code-genearators Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VitaliyBoyko VitaliyBoyko VitaliyBoyko approved these changes

Assignees

@VitaliyBoyko VitaliyBoyko

Labels
Award: test coverage Complex Partner: Atwix partners-contribution Progress: approved Progress: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ProkopovVitaliy @VitaliyBoyko @magento-engcom-team