Skip to content

1179: moved graphql dependent actions to the withJsGraphQl.xml config… #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

VitaliyBoyko
Copy link
Contributor

… to avoid fatal errors if GraphqlJs plugin is not installed

Description (*)
GraphQl-dependent functionality should be declared in withJsGraphQl.xml file

Fixed Issues (if relevant)

  1. Fixes [Bug] com.intellij.diagnostic.PluginException: Cannot create class com.magento.idea.magento2plugin.actions.context.xml.NewGraphQLSchemaAction #1179

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

… to avoid fatal errors if GraphqlJs plugin is not installed
@VitaliyBoyko VitaliyBoyko changed the base branch from 5.0.0-develop to 4.4.0-develop September 16, 2022 15:55
@bohdan-harniuk bohdan-harniuk self-requested a review September 16, 2022 16:09
Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@bohdan-harniuk bohdan-harniuk merged commit adfae0d into 4.4.0-develop Sep 16, 2022
@VitaliyBoyko VitaliyBoyko deleted the 1179-graphql-dependent-actions-in-general-file branch December 16, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] com.intellij.diagnostic.PluginException: Cannot create class com.magento.idea.magento2plugin.actions.context.xml.NewGraphQLSchemaAction
2 participants