Module name declaration inspection flags valid code

[lfolco]

Describe the bug (*)

Adding a ExpressionConverter translation to registration.php causes the invalid module name inspection to fire. When using long table names, you can add a translation to the registration.php file in order to have foreign key names that are more descriptive, instead of the ones that it generates like FK_1398WO8U4OR8UEO48ROE4OTJO3. This translation gets flagged as an error.

To Reproduce (*)

Steps to reproduce the behavior:

1. Open up any registration.php file
2. Add the following line: \Magento\Framework\DB\ExpressionConverter::addTranslate('subscriber_queue', 'subqueue');
3. See error "Provided module name does not match expected"

Please complete the following information: (*)

• OS: MacOS
• PhpStorm/Intellij version: 2021.1.4
• Plugin Version: 4.0.0

[m2-assistant]

Hi @lfolco. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[bohdan-harniuk]

Hello, @lfolco!

Could you please share code block for better understanding?

Thanks, Bohdan

[lfolco]

use Magento\Framework\Component\ComponentRegistrar;

ComponentRegistrar::register(ComponentRegistrar::MODULE, 'Aescripts_NotifyVersion', __DIR__);

// Generated FK names were too long, need to shorten a few things
\Magento\Framework\DB\ExpressionConverter::addTranslate('email_tracking', 'trck');
\Magento\Framework\DB\ExpressionConverter::addTranslate('notify_version', 'notifyver');

[bohdan-harniuk]

Hello, @lfolco!

Thank you for your help.
I'he reproduced this bug:

[bohdan-harniuk]

Hello, @lfolco!

I've fixed this bug.
Fix will be delivered in the upcoming release: 4.2.2

Regards,

[lfolco]

Thank you!