33297: Eliminate AspectMock from DataExtensionUtilTest #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbess
approved these changes
Jul 5, 2021
5 tasks
karyna-t
changed the title
bohdan-harniuk
added
Partner: Atwix
partners-contribution
|
@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework |
|
@jilu1 the pull request successfully imported. |
karyna-t
force-pushed
the
improvement/mftf-33297-eliminate-aspect-mock-from-DataExtensionUtilTest-and-OperationDataArrayResolverTest
branch
from
29a3e1e to
9dfd3e3
Compare
|
@karyna-tsymbal-atwix |
karyna-t
deleted the
improvement/mftf-33297-eliminate-aspect-mock-from-DataExtensionUtilTest-and-OperationDataArrayResolverTest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Eliminated AspectMock usage from
dev/tests/unit/Magento/FunctionalTestFramework/DataGenerator/Util/DataExtensionUtilTest.phpIn the scope of this ticket I also refactored
dev/tests/unit/Magento/FunctionalTestFramework/DataGenerator/Persist/OperationDataArrayResolverTest.phpDataObjectHandler instance, mocked with AspectMock, is not cleaned in OperationDataArrayResolverTest, thus it broke DataExtensionUtilTest after my refactoring. As our main purpose to eliminate AspectMock completely, I decided to refactor OperationDataArrayResolverTest also.
Fixed Issues (if relevant)
Contribution checklist