Skip to content

33292 replace AspectMock from BaseGenerateCommandTest #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 26, 2021
Merged

33292 replace AspectMock from BaseGenerateCommandTest #840

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3396029
33292 replace AspectMock from BaseGenerateCommandTest
Jun 28, 2021
a449f07
33292 change tearDown method
Jul 16, 2021
bbec23a
33292: aspect mock replacement, unit test refactoring
bohdan-harniuk Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
115 changes: 85 additions & 30 deletions dev/tests/unit/Magento/FunctionalTestFramework/Console/BaseGenerateCommandTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,24 +3,46 @@
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
declare(strict_types=1);

namespace tests\unit\Magento\FunctionalTestFramework\Console;

use AspectMock\Test as AspectMock;
use PHPUnit\Framework\TestCase;
use Exception;
use Magento\FunctionalTestingFramework\Console\BaseGenerateCommand;
use Magento\FunctionalTestingFramework\Suite\Objects\SuiteObject;
use Magento\FunctionalTestingFramework\Suite\Handlers\SuiteObjectHandler;
use Magento\FunctionalTestingFramework\Test\Objects\TestObject;
use Magento\FunctionalTestingFramework\Suite\Objects\SuiteObject;
use Magento\FunctionalTestingFramework\Test\Handlers\TestObjectHandler;
use Magento\FunctionalTestingFramework\Test\Objects\TestObject;
use PHPUnit\Framework\TestCase;
use ReflectionClass;
use ReflectionException;
use ReflectionProperty;

class BaseGenerateCommandTest extends TestCase
{
public function tearDown(): void
/**
* @inheritDoc
*/
protected function tearDown(): void
{
AspectMock::clean();
$handler = TestObjectHandler::getInstance();
$testsProperty = new ReflectionProperty(TestObjectHandler::class, 'tests');
$testsProperty->setAccessible(true);
$testsProperty->setValue($handler, []);
$testObjectHandlerProperty = new ReflectionProperty(TestObjectHandler::class, 'testObjectHandler');
$testObjectHandlerProperty->setAccessible(true);
$testObjectHandlerProperty->setValue($handler);

$handler = SuiteObjectHandler::getInstance();
$suiteObjectsProperty = new ReflectionProperty(SuiteObjectHandler::class, 'suiteObjects');
$suiteObjectsProperty->setAccessible(true);
$suiteObjectsProperty->setValue($handler, []);
$suiteObjectHandlerProperty = new ReflectionProperty(SuiteObjectHandler::class, 'instance');
$suiteObjectHandlerProperty->setAccessible(true);
$suiteObjectHandlerProperty->setValue($handler);
}

public function testOneTestOneSuiteConfig()
public function testOneTestOneSuiteConfig(): void
{
$testOne = new TestObject('Test1', [], [], []);
$suiteOne = new SuiteObject('Suite1', ['Test1' => $testOne], [], []);
Expand All @@ -35,7 +57,7 @@ public function testOneTestOneSuiteConfig()
$this->assertEquals($expected, $actual);
}

public function testOneTestTwoSuitesConfig()
public function testOneTestTwoSuitesConfig(): void
{
$testOne = new TestObject('Test1', [], [], []);
$suiteOne = new SuiteObject('Suite1', ['Test1' => $testOne], [], []);
Expand All @@ -51,7 +73,7 @@ public function testOneTestTwoSuitesConfig()
$this->assertEquals($expected, $actual);
}

public function testOneTestOneGroup()
public function testOneTestOneGroup(): void
{
$testOne = new TestObject('Test1', [], ['group' => ['Group1']], []);

Expand All @@ -65,7 +87,7 @@ public function testOneTestOneGroup()
$this->assertEquals($expected, $actual);
}

public function testThreeTestsTwoGroup()
public function testThreeTestsTwoGroup(): void
{
$testOne = new TestObject('Test1', [], ['group' => ['Group1']], []);
$testTwo = new TestObject('Test2', [], ['group' => ['Group1']], []);
Expand All @@ -81,7 +103,7 @@ public function testThreeTestsTwoGroup()
$this->assertEquals($expected, $actual);
}

public function testOneTestOneSuiteOneGroupConfig()
public function testOneTestOneSuiteOneGroupConfig(): void
{
$testOne = new TestObject('Test1', [], ['group' => ['Group1']], []);
$suiteOne = new SuiteObject('Suite1', ['Test1' => $testOne], [], []);
Expand All @@ -96,7 +118,7 @@ public function testOneTestOneSuiteOneGroupConfig()
$this->assertEquals($expected, $actual);
}

public function testTwoTestOneSuiteTwoGroupConfig()
public function testTwoTestOneSuiteTwoGroupConfig(): void
{
$testOne = new TestObject('Test1', [], ['group' => ['Group1']], []);
$testTwo = new TestObject('Test2', [], ['group' => ['Group2']], []);
Expand All @@ -112,7 +134,7 @@ public function testTwoTestOneSuiteTwoGroupConfig()
$this->assertEquals($expected, $actual);
}

public function testTwoTestTwoSuiteOneGroupConfig()
public function testTwoTestTwoSuiteOneGroupConfig(): void
{
$testOne = new TestObject('Test1', [], ['group' => ['Group1']], []);
$testTwo = new TestObject('Test2', [], ['group' => ['Group1']], []);
Expand All @@ -131,10 +153,12 @@ public function testTwoTestTwoSuiteOneGroupConfig()

/**
* Test specific usecase of a test that is in a group with the group being called along with the suite
* i.e. run:group Group1 Suite1
* @throws \Exception
* i.e. run:group Group1 Suite1.
*
* @return void
* @throws Exception
*/
public function testThreeTestOneSuiteOneGroupMix()
public function testThreeTestOneSuiteOneGroupMix(): void
{
$testOne = new TestObject('Test1', [], [], []);
$testTwo = new TestObject('Test2', [], [], []);
Expand All @@ -156,7 +180,7 @@ public function testThreeTestOneSuiteOneGroupMix()
$this->assertEquals($expected, $actual);
}

public function testSuiteToTestSyntax()
public function testSuiteToTestSyntax(): void
{
$testOne = new TestObject('Test1', [], [], []);
$suiteOne = new SuiteObject(
Expand All @@ -175,51 +199,82 @@ public function testSuiteToTestSyntax()
}

/**
* Mock handlers to skip parsing
* Mock handlers to skip parsing.
*
* @param array $testArray
* @param array $suiteArray
* @throws \Exception
*
* @return void
* @throws Exception
*/
public function mockHandlers($testArray, $suiteArray)
public function mockHandlers(array $testArray, array $suiteArray): void
{
AspectMock::double(TestObjectHandler::class, ['initTestData' => ''])->make();
// bypass the initTestData method
$testObjectHandlerClass = new ReflectionClass(TestObjectHandler::class);
$constructor = $testObjectHandlerClass->getConstructor();
$constructor->setAccessible(true);
$testObjectHandlerObject = $testObjectHandlerClass->newInstanceWithoutConstructor();
$constructor->invoke($testObjectHandlerObject);

$testObjectHandlerProperty = new ReflectionProperty(TestObjectHandler::class, 'testObjectHandler');
$testObjectHandlerProperty->setAccessible(true);
$testObjectHandlerProperty->setValue($testObjectHandlerObject);

$handler = TestObjectHandler::getInstance();
$property = new \ReflectionProperty(TestObjectHandler::class, 'tests');
$property = new ReflectionProperty(TestObjectHandler::class, 'tests');
$property->setAccessible(true);
$property->setValue($handler, $testArray);

AspectMock::double(SuiteObjectHandler::class, ['initSuiteData' => ''])->make();
// bypass the initTestData method
$suiteObjectHandlerClass = new ReflectionClass(SuiteObjectHandler::class);
$constructor = $suiteObjectHandlerClass->getConstructor();
$constructor->setAccessible(true);
$suiteObjectHandlerObject = $suiteObjectHandlerClass->newInstanceWithoutConstructor();
$constructor->invoke($suiteObjectHandlerObject);

$suiteObjectHandlerProperty = new ReflectionProperty(SuiteObjectHandler::class, 'instance');
$suiteObjectHandlerProperty->setAccessible(true);
$suiteObjectHandlerProperty->setValue($suiteObjectHandlerObject);

$handler = SuiteObjectHandler::getInstance();
$property = new \ReflectionProperty(SuiteObjectHandler::class, 'suiteObjects');
$property = new ReflectionProperty(SuiteObjectHandler::class, 'suiteObjects');
$property->setAccessible(true);
$property->setValue($handler, $suiteArray);
}

/**
* Changes visibility and runs getTestAndSuiteConfiguration
* Changes visibility and runs getTestAndSuiteConfiguration.
*
* @param array $testArray
*
* @return string
* @throws ReflectionException
*/
public function callTestConfig($testArray)
public function callTestConfig(array $testArray): string
{
$command = new BaseGenerateCommand();
$class = new \ReflectionClass($command);
$class = new ReflectionClass($command);
$method = $class->getMethod('getTestAndSuiteConfiguration');
$method->setAccessible(true);

return $method->invokeArgs($command, [$testArray]);
}

/**
* Changes visibility and runs getGroupAndSuiteConfiguration
* Changes visibility and runs getGroupAndSuiteConfiguration.
*
* @param array $groupArray
*
* @return string
* @throws ReflectionException
*/
public function callGroupConfig($groupArray)
public function callGroupConfig(array $groupArray): string
{
$command = new BaseGenerateCommand();
$class = new \ReflectionClass($command);
$class = new ReflectionClass($command);
$method = $class->getMethod('getGroupAndSuiteConfiguration');
$method->setAccessible(true);

return $method->invokeArgs($command, [$groupArray]);
}
}