Added the 'waitForPageLoad' action after every 'amOnPage' action #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinBKozan
suggested changes
Apr 18, 2018
| * @throws \Exception | ||
| * @return void | ||
| */ | ||
| public function amOnPage($page) |
There was a problem hiding this comment.
I assume that the goal here was to override the WebDriver's definition of amOnPage correct? If so, this function belongs in MagentoWebDriver.php, where we provide custom functions and redefinitions of some of the base Codeception commands.
| { | ||
| $url = Uri::appendPath($this->config['url'], $page); | ||
| $this->debugSection('GET', $url); | ||
| $this->webDriver->get($url); |
There was a problem hiding this comment.
Instead of defining these three lines, you should just call parent::amOnPage($page) to prevent duplicate code (since we're not changing amOnPage behaviour, just adding to it).
okolesnyk
added
Partner: Rocket Web
…ing-framework into waitforpageload-after-amonpage
KevinBKozan
approved these changes
Apr 30, 2018
|
Changes look great, thank you very much for your contribution! |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Jul 29, 2021
…2-functional-testing-framework-850 [Imported] 33309: Eliminated AspectMock usage from TestGeneratorTest.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Many times when various tests are running, there will be times when using the 'amOnPage' action, which will throw various errors due to the fact that some of the javascript elements, that the test is supposed to interact with, haven't loaded it. It might make sense to just automatically add the 'waitForPageLoad' action after the 'amOnPage' action.
Contribution checklist