Skip to content

MQE-2158: support using actions from multiple modules in Suites #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 5, 2020

Conversation

jilu1
Copy link
Contributor

@jilu1 jilu1 commented Jul 31, 2020

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented Jul 31, 2020

Coverage Status

Coverage increased (+0.2%) to 56.214% when pulling 9b20fff on MQE-2158 into 6529865 on develop.

@soumyau
Copy link
Contributor

soumyau commented Aug 3, 2020

changes look good. Had a couple of questions -

  1. What is the reasoning behind accessing actions in other custom modules from MagentoWebDriver? Can it live in a parent class that all other custom modules extend?
  2. How do I use actions outside of MagentoWebDriver in a Helper? Can that use case be included in a verification test?

@jilu1
Copy link
Contributor Author

jilu1 commented Aug 4, 2020

changes look good. Had a couple of questions -

  1. What is the reasoning behind accessing actions in other custom modules from MagentoWebDriver? Can it live in a parent class that all other custom modules extend?

An alternative solution is use a base module that all our modules extend but I think that's too overkill. MagentoWebDriver is for sure used in Suite to handling sessions.

  1. How do I use actions outside of MagentoWebDriver in a Helper? Can that use case be included in a verification test?

I think helpers can access anything if they want to. Tests to show how helps use actions from other modules if needed is not in scope of this story.

@soumyau
Copy link
Contributor

soumyau commented Aug 5, 2020

changes look good. Had a couple of questions -

  1. What is the reasoning behind accessing actions in other custom modules from MagentoWebDriver? Can it live in a parent class that all other custom modules extend?

An alternative solution is use a base module that all our modules extend but I think that's too overkill.
MagentoWebDriver is for sure used in Suite to handling sessions.
Sounds good.

  1. How do I use actions outside of MagentoWebDriver in a Helper? Can that use case be included in a verification test?

I think helpers can access anything if they want to. Tests to show how helps use actions from other modules if needed is not in scope of this story.
looks like $this->getModule('\Magento\FunctionalTestingFramework\Module\MagentoWebDriver') is used in Helper classes and suites. Since actions are moved out of this class, maybe a similar mechanism of accessing container will be useful in case of Helpers too.

@jilu1 jilu1 merged commit da3465c into develop Aug 5, 2020
@tomreece tomreece deleted the MQE-2158 branch August 19, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants