Skip to content

MQE-1974: Report used deprecated metadata in Test #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 3, 2020
Merged

MQE-1974: Report used deprecated metadata in Test #772

merged 5 commits into from
Aug 3, 2020

Conversation

soumyau
Copy link
Contributor

@soumyau soumyau commented Jul 28, 2020 •
edited
Loading

Changes -

  1. Added logging capability in OperationDefinitionObject for used deprecated operation in a test. ( logged at runtime)
  2. Updated MftfLogger to log all warnings and deprecations during test generation and runtime. This behavior was previously changed to log only during test generation to make mftf.log smaller. All Operation classes are initialized only during runtime; so these validations happen at runtime.
  3. Name validations for DataObjectHandler occur twice during test generation and test runs - changed it to once. This ensures all logs in mftf.log are unique.
  4. Modified deprecation warning messages across all entities

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 55.989% when pulling 98a678d on MQE-1974 into 98d9a3b on develop.

@coveralls
Copy link

coveralls commented Jul 28, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.08%) to 55.997% when pulling 3ec4130 on MQE-1974 into 081aa48 on develop.

@soumyau soumyau force-pushed the MQE-1974 branch 2 times, most recently from 914f366 to 7fc5d5a Compare July 28, 2020 16:09
jilu1
jilu1 reviewed Jul 28, 2020
View reviewed changes
jilu1
jilu1 reviewed Jul 28, 2020
View reviewed changes
jilu1
jilu1 reviewed Jul 31, 2020
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add verification test according to AC

@soumyau soumyau force-pushed the MQE-1974 branch 5 times, most recently from 4e15a5b to 45a8142 Compare August 3, 2020 13:32
@soumyau
Copy link
Contributor Author

soumyau commented Aug 3, 2020

Please add verification test according to AC

done

jilu1
jilu1 approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good! Have you rerun the UR builds after the change?

@soumyau
Copy link
Contributor Author

soumyau commented Aug 3, 2020 •
edited
Loading

It looks good! Have you rerun the UR builds after the change?

reran build - looks good. https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/34895/

@soumyau soumyau merged commit 6529865 into develop Aug 3, 2020
@tomreece tomreece deleted the MQE-1974 branch August 19, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jilu1 jilu1 jilu1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soumyau @coveralls @jilu1