Skip to content

MQE-2144: Allure captures only <after> steps when test fails with Web… #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 15, 2020

Conversation

soumyau
Copy link
Contributor

@soumyau soumyau commented Jun 12, 2020

…DriverCurlException

suppressed exception generate allure correctly

exception thrown during capture of browser logs in afterStep of TestContextExtension breaks allure also causes test to fail in entirety. Implemented a fall through in case of exceptions in this function. Browser issues if they persist will get captured in the next test step.

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

…DriverCurlException

suppressed exception generate allure correctly
@coveralls
Copy link

coveralls commented Jun 12, 2020

Coverage Status

Coverage remained the same at 55.85% when pulling b8c0f86 on MQE-2144 into bd2eee2 on develop.

Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@soumyau soumyau merged commit ec9c4d3 into develop Jun 15, 2020
@tomreece tomreece deleted the MQE-2144 branch July 27, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants