MQE-2140: [chrome81] dragAndDrop with x and y offsets no longer works #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soumyau
changed the title
jilu1
suggested changes
Jun 2, 2020
There was a problem hiding this comment.
- Code change looks good to me.
- Please check with @KevinBKozan on why we need to use custom steps instead of the web driver drag and drop function in the first place. I remember it's some page builder requirements.
- I think mainline 2.4 has been cleaned up. Please update your UR build to make sure your change works for old chrome version for drag and drop tests and/or test changes if needed.
@jilu1 it was a pagebuilder requirement, yes. If you remove them and pagebuilder tests still pass then it should be fine. |
jilu1
reviewed
Jun 11, 2020
| parent::dragAndDrop($source, $target); | ||
| $action->clickAndHold($snodes); | ||
| $action->moveToElement($tnodes); | ||
| $action->release($tnodes)->perform(); |
There was a problem hiding this comment.
Any reason for this change? I remember this issue only applies for dragAndDrop with offset.
There was a problem hiding this comment.
for chrome 81, separating out dragAndDrop into it's native functions helped resolve couple of issues with drag and drop without offsets too, hence the fix.
There was a problem hiding this comment.
Interesting to know. Maybe php webdriver need to make some change? Are we on recent version?
There was a problem hiding this comment.
yes, we are on latest version of php webdriver. It's probably page builder specific.
jilu1
suggested changes
Jun 11, 2020
There was a problem hiding this comment.
- Changes look good. I only have one question.
- Please rebase your branch. There are too many revision of the MagentoWebDriver.php in your branch.
- From the test fix, it looks like instead of calculating x and y offset, we now use -1. Can we document how user can calculate this value? Will it always be -1?
- Pull latest mainline and run builds with all required extensions to make sure that fix works in all dragAndDrop tests for Chrome65 and Chrome81 if you have not done so.
|
jilu1
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed Issues (if relevant)
Contribution checklist