Skip to content

Mqe 2135 #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 29, 2020
Merged

Mqe 2135 #721

merged 5 commits into from
May 29, 2020

Conversation

jilu1
Copy link
Contributor

@jilu1 jilu1 commented May 29, 2020

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented May 29, 2020

Coverage Status

Coverage decreased (-0.03%) to 55.91% when pulling 1481bc7 on MQE-2135 into e8bc533 on develop.

Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 It'll be good to remove file specific references like mftf-annotations-static-check.txt from .gitignore as static-results is a sub-folder to _output which is in the list.

@jilu1
Copy link
Contributor Author

jilu1 commented May 29, 2020

Looks good 👍 It'll be good to remove file specific references like mftf-annotations-static-check.txt from .gitignore as static-results is a sub-folder to _output which is in the list.

Removed mftf-annotations-static-check.txt from .gitignore.

@jilu1 jilu1 merged commit 64e7788 into develop May 29, 2020
@jilu1 jilu1 deleted the MQE-2135 branch June 9, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants